You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As @sgilmore10 pointed out in #37250 (comment), it would make sense to add tests which verify that the NumFields, BitWidth, and ID fields can not be modified on any FixedWidthType.
Component(s)
MATLAB
The text was updated successfully, but these errors were encountered:
…`BitWidth`, and `ID` properties can not be modified to `hFixedWidth` test class (#37316)
### Rationale for this change
As @ sgilmore10 pointed out in #37250 (comment), it makes sense to move the tests which verify that the `NumFields`, `BitWidth`, and `ID` properties cannot be set into the `hFixedWidthType` superclass, rather than having these tests implemented in `tTime32Type` and `tTime64Type`, since they are common to all fixed width types.
### What changes are included in this PR?
1. Moved tests which verify that the `BitWidth`, `NumFields`, and `ID` properties cannot be set out of the `tTime32Type` and `tTime64Type` classes and into the superclass `hFixedWidthType`.
2. Fixed typo in `tTime32Type` and `tTime64Type`. Changed variable name `schema` to `type`.
### Are these changes tested?
Yes.
1. Moved tests which verify that the `BitWidth`, `NumFields`, and `ID` properties cannot be set out of the `tTime32Type` and `tTime64Type` classes and into the superclass `hFixedWidthType`.
### Are there any user-facing changes?
No.
This pull request only modifies tests.
* Closes: #37253
Authored-by: Kevin Gurney <kgurney@mathworks.com>
Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
…lds`, `BitWidth`, and `ID` properties can not be modified to `hFixedWidth` test class (apache#37316)
### Rationale for this change
As @ sgilmore10 pointed out in apache#37250 (comment), it makes sense to move the tests which verify that the `NumFields`, `BitWidth`, and `ID` properties cannot be set into the `hFixedWidthType` superclass, rather than having these tests implemented in `tTime32Type` and `tTime64Type`, since they are common to all fixed width types.
### What changes are included in this PR?
1. Moved tests which verify that the `BitWidth`, `NumFields`, and `ID` properties cannot be set out of the `tTime32Type` and `tTime64Type` classes and into the superclass `hFixedWidthType`.
2. Fixed typo in `tTime32Type` and `tTime64Type`. Changed variable name `schema` to `type`.
### Are these changes tested?
Yes.
1. Moved tests which verify that the `BitWidth`, `NumFields`, and `ID` properties cannot be set out of the `tTime32Type` and `tTime64Type` classes and into the superclass `hFixedWidthType`.
### Are there any user-facing changes?
No.
This pull request only modifies tests.
* Closes: apache#37253
Authored-by: Kevin Gurney <kgurney@mathworks.com>
Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
Describe the enhancement requested
As @sgilmore10 pointed out in #37250 (comment), it would make sense to add tests which verify that the
NumFields
,BitWidth
, andID
fields can not be modified on anyFixedWidthType
.Component(s)
MATLAB
The text was updated successfully, but these errors were encountered: