[Python] Include cloudpickle in pytests that pickle objects #37254
Comments
kou
pushed a commit
that referenced
this issue
Aug 24, 2023
…kle and cloudpickle modules (#37255) ### Rationale for this change Cloudpickle was not tested in most parts of the pyarrow test suite. Improving this coverage will make the Cython 3.0.0 upgrade cleaner as cloudpickle was failing in a few places where the default pickle module was not. This has been verified using Cython 0.29.36. ### What changes are included in this PR? * `__reduce__` methods that need to pass kwargs have been changed from classmethod to staticmethod * All pytests that pickle objects are parameterized to use both `pickle` and `cloudpickle` ### Are these changes tested? Yes, pytests run successfully with Cython 0.29.36 ### Are there any user-facing changes? No. * Closes: #37254 Authored-by: Dane Pitkin <dane@voltrondata.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
…he pickle and cloudpickle modules (apache#37255) ### Rationale for this change Cloudpickle was not tested in most parts of the pyarrow test suite. Improving this coverage will make the Cython 3.0.0 upgrade cleaner as cloudpickle was failing in a few places where the default pickle module was not. This has been verified using Cython 0.29.36. ### What changes are included in this PR? * `__reduce__` methods that need to pass kwargs have been changed from classmethod to staticmethod * All pytests that pickle objects are parameterized to use both `pickle` and `cloudpickle` ### Are these changes tested? Yes, pytests run successfully with Cython 0.29.36 ### Are there any user-facing changes? No. * Closes: apache#37254 Authored-by: Dane Pitkin <dane@voltrondata.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
Right now, all but one of the pytests that test pickle functionality only tests with the default python
picklemodule. Let's parameterize these tests to also test with thecloudpicklemodule.Component(s)
Python
The text was updated successfully, but these errors were encountered: