Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ruby] Add explicit the "csv" gem dependency for Ruby 3.4 or later #37259

Closed
kou opened this issue Aug 18, 2023 · 4 comments · Fixed by #37506
Closed

[Ruby] Add explicit the "csv" gem dependency for Ruby 3.4 or later #37259

kou opened this issue Aug 18, 2023 · 4 comments · Fixed by #37506
Assignees
@heronshoes
Labels
Component: Ruby Type: enhancement
Milestone
14.0.0

Comments

@kou
Copy link
Member

kou commented Aug 18, 2023

Describe the enhancement requested

The "csv" gem is a default gem for now but it'll be just a bundled gem in Ruby 3.4.
If red-arrow doesn't have an explicit the "csv" gem dependency, require "csv" may be failed with Ruby 3.4 or later.

Ruby master reports the following warning when we require red-arrow:

$ ruby -v -e 'require "red-arrow"'
ruby 3.3.0dev (2023-08-17T21:17:31Z master 5d48825d55) [x86_64-linux]
.../lib/arrow/csv-loader.rb:18: warning: csv which will be not part of the default gems since Ruby 3.4.0

Component(s)

Ruby
@kou
Copy link
Member Author

kou commented Aug 18, 2023

@heronshoes @otegami Are you interested in this?

@heronshoes
Copy link
Contributor

@kou I want to work on this. Thanks.
Is this issue is for Ruby 3.3.0 or 3.4?

@kou
Copy link
Member Author

kou commented Aug 18, 2023

Thanks!
It's for 3.4 not 3.3.

@heronshoes
Copy link
Contributor

I understood. Thank you!

heronshoes added a commit to heronshoes/arrow that referenced this issue Sep 1, 2023
@heronshoes
apacheGH-37259: [Ruby] Add explicit csv gem dependency
90f8b64
@heronshoes heronshoes mentioned this issue Sep 1, 2023
Merged
heronshoes added a commit to heronshoes/arrow that referenced this issue Sep 1, 2023
@heronshoes
apacheGH-37259: [Ruby] Add explicit csv gem dependency
0b7b1d3
@kou kou closed this as completed in #37506 Sep 1, 2023
kou pushed a commit that referenced this issue Sep 1, 2023
@heronshoes
GH-37259: [Ruby] Add explicit csv gem dependency (#37506)
c0998b1 
### Rationale for this change

The "csv" gem is a default gem for now but it will be a bundled gem in Ruby 3.4.
Bundled gem requires an explicit gem dependency.

This will cause failure when we do `require "csv"` in Ruby 3.4 (this means in master branch of Ruby = ruby 3.3.0dev for now). See examples in #37259.

### What changes are included in this PR?

Added `gem "csv"` in gemspec's runtime dependency of Red Arrow.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Users will use 'csv' gem from rubygems, not bundled, for Ruby < 3.4 .

* Closes: #37259

Authored-by: Hirokazu SUZUKI <heronshoes877@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 14.0.0 milestone Sep 1, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@heronshoes @loicalleyne
apacheGH-37259: [Ruby] Add explicit csv gem dependency (apache#37506)
887807e 
### Rationale for this change

The "csv" gem is a default gem for now but it will be a bundled gem in Ruby 3.4.
Bundled gem requires an explicit gem dependency.

This will cause failure when we do `require "csv"` in Ruby 3.4 (this means in master branch of Ruby = ruby 3.3.0dev for now). See examples in apache#37259.

### What changes are included in this PR?

Added `gem "csv"` in gemspec's runtime dependency of Red Arrow.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Users will use 'csv' gem from rubygems, not bundled, for Ruby < 3.4 .

* Closes: apache#37259

Authored-by: Hirokazu SUZUKI <heronshoes877@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@heronshoes @dgreiss
apacheGH-37259: [Ruby] Add explicit csv gem dependency (apache#37506)
1e0e354 
### Rationale for this change

The "csv" gem is a default gem for now but it will be a bundled gem in Ruby 3.4.
Bundled gem requires an explicit gem dependency.

This will cause failure when we do `require "csv"` in Ruby 3.4 (this means in master branch of Ruby = ruby 3.3.0dev for now). See examples in apache#37259.

### What changes are included in this PR?

Added `gem "csv"` in gemspec's runtime dependency of Red Arrow.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Users will use 'csv' gem from rubygems, not bundled, for Ruby < 3.4 .

* Closes: apache#37259

Authored-by: Hirokazu SUZUKI <heronshoes877@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heronshoes heronshoes

Labels
Component: Ruby Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37259: [Ruby] Add explicit csv gem dependency heronshoes/arrow
2 participants
@kou @heronshoes