-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C++][Flight] test_definitions.cc failing on test-fedora-35-cpp nightly #37294
Comments
It might also be related to #36379. |
I guess we can't use matchers, hmm. |
Well, we use them in many places already, don't we? This seems more of an issue of not supporting C++17 stdlib classes in matchers. |
lidavidm
added a commit
to lidavidm/arrow
that referenced
this issue
Aug 22, 2023
lidavidm
added a commit
to lidavidm/arrow
that referenced
this issue
Aug 23, 2023
kou
pushed a commit
that referenced
this issue
Aug 24, 2023
### Rationale for this change Apparently not all versions of GTest/GMock handle `testing::HasSubstr` against a `std::string_view`. ### What changes are included in this PR? Explicitly wrap in `std::string`. ### Are these changes tested? They are the tests. ### Are there any user-facing changes? No. * Closes: #37294 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
…7314) ### Rationale for this change Apparently not all versions of GTest/GMock handle `testing::HasSubstr` against a `std::string_view`. ### What changes are included in this PR? Explicitly wrap in `std::string`. ### Are these changes tested? They are the tests. ### Are there any user-facing changes? No. * Closes: apache#37294 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
test-fedora-35-cpp is failing with the following error:
Based on the crossbow report these are the commits that were added on the first failure some days ago:
77d87a9...f93929f
It does seem related to: 9f183fc
Component(s)
C++, FlightRPC
The text was updated successfully, but these errors were encountered: