Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Add a Dictionary Compaction Function For DictionaryArray #37378

Closed
R-JunmingChen opened this issue Aug 25, 2023 · 0 comments · Fixed by #37418
Closed

[C++] Add a Dictionary Compaction Function For DictionaryArray #37378

R-JunmingChen opened this issue Aug 25, 2023 · 0 comments · Fixed by #37418
Assignees
@R-JunmingChen
Labels
Component: C++ Type: enhancement
Milestone
15.0.0

Comments

@R-JunmingChen
Copy link
Contributor

R-JunmingChen commented Aug 25, 2023 •
edited
Loading

Describe the enhancement requested

DictionaryArray could have unused dictionary values. This is an obstacle to finish #37100. A Dictionary Compaction Function, which removes unused values in dictionary, is useful to solve the problem. Besides, #37277 has the same request in Go implementation.

Here is a pesudo example:

dict_a
dictionary: ["1", "2", "3"]
indices: [0, 1, 0, 1]

dictionary_compaction(dict_a)
dictionary: ["1", "2"]
indices: [0, 1, 0, 1]

Component(s)

C++
@github-actions github-actions bot mentioned this issue Aug 28, 2023
Merged
bkietz added a commit that referenced this issue Oct 11, 2023
@R-JunmingChen @benibus @bkietz
GH-37378: [C++] Add A Dictionary Compaction Function For DictionaryAr…
73454b7 
…ray (#37418)

### Rationale for this change
A Dictionary Compaction Function for DictionaryArray is supported.

### What changes are included in this PR?
Add a Function for Dictionary Compaction

### Are these changes tested?
Yes

Are there any user-facing changes?
No
* Closes: #37378

Lead-authored-by: Junming Chen <junming.chen.r@outlook.com>
Co-authored-by: Ben Harkins <60872452+benibus@users.noreply.github.com>
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
@bkietz bkietz added this to the 15.0.0 milestone Oct 11, 2023
llama90 pushed a commit to llama90/arrow that referenced this issue Oct 12, 2023
@R-JunmingChen @benibus
@bkietz @llama90
apacheGH-37378: [C++] Add A Dictionary Compaction Function For Dictio…
6a1116b 
…naryArray (apache#37418)

### Rationale for this change
A Dictionary Compaction Function for DictionaryArray is supported.

### What changes are included in this PR?
Add a Function for Dictionary Compaction

### Are these changes tested?
Yes

Are there any user-facing changes?
No
* Closes: apache#37378

Lead-authored-by: Junming Chen <junming.chen.r@outlook.com>
Co-authored-by: Ben Harkins <60872452+benibus@users.noreply.github.com>
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@R-JunmingChen @benibus @bkietz
apacheGH-37378: [C++] Add A Dictionary Compaction Function For Dictio…
57eb420 
…naryArray (apache#37418)

### Rationale for this change
A Dictionary Compaction Function for DictionaryArray is supported.

### What changes are included in this PR?
Add a Function for Dictionary Compaction

### Are these changes tested?
Yes

Are there any user-facing changes?
No
* Closes: apache#37378

Lead-authored-by: Junming Chen <junming.chen.r@outlook.com>
Co-authored-by: Ben Harkins <60872452+benibus@users.noreply.github.com>
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@R-JunmingChen @benibus
@bkietz @loicalleyne
apacheGH-37378: [C++] Add A Dictionary Compaction Function For Dictio…
cc4b79c 
…naryArray (apache#37418)

### Rationale for this change
A Dictionary Compaction Function for DictionaryArray is supported.

### What changes are included in this PR?
Add a Function for Dictionary Compaction

### Are these changes tested?
Yes

Are there any user-facing changes?
No
* Closes: apache#37378

Lead-authored-by: Junming Chen <junming.chen.r@outlook.com>
Co-authored-by: Ben Harkins <60872452+benibus@users.noreply.github.com>
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@R-JunmingChen @benibus
@bkietz @dgreiss
apacheGH-37378: [C++] Add A Dictionary Compaction Function For Dictio…
f058b90 
…naryArray (apache#37418)

### Rationale for this change
A Dictionary Compaction Function for DictionaryArray is supported.

### What changes are included in this PR?
Add a Function for Dictionary Compaction

### Are these changes tested?
Yes

Are there any user-facing changes?
No
* Closes: apache#37378

Lead-authored-by: Junming Chen <junming.chen.r@outlook.com>
Co-authored-by: Ben Harkins <60872452+benibus@users.noreply.github.com>
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@R-JunmingChen R-JunmingChen

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-37378: [C++] Add A Dictionary Compaction Function For DictionaryArray R-JunmingChen/arrow
2 participants
@bkietz @R-JunmingChen