[C++][Parquet] Thrift: Generate movable_types

[mapleFU]

Describe the enhancement requested

By default, we're using

thrift --gen cpp -out src/generated src/parquet/parquet.thrift

When generating thrift. When I gothrough the code in PageIndex, I found ColumnIndex is copied here:

std::unique_ptr<ColumnIndex> ColumnIndex::Make(const ColumnDescriptor& descr,
                                               const void* serialized_index,
                                               uint32_t index_len,
                                               const ReaderProperties& properties) {
  format::ColumnIndex column_index;
  ThriftDeserializer deserializer(properties);
  deserializer.DeserializeMessage(reinterpret_cast<const uint8_t*>(serialized_index),
                                  &index_len, &column_index);
  switch (descr.physical_type()) {
    // ...
    case Type::DOUBLE:
      return std::make_unique<TypedColumnIndexImpl<DoubleType>>(descr,  column_index);
    case Type::BYTE_ARRAY:
      return std::make_unique<TypedColumnIndexImpl<ByteArrayType>>(descr,  column_index);
    case Type::FIXED_LEN_BYTE_ARRAY:
      return std::make_unique<TypedColumnIndexImpl<FLBAType>>(descr,  column_index);
    case Type::UNDEFINED:
      return nullptr;
  }
  ::arrow::Unreachable("Cannot make ColumnIndex of an unknown type");
  return nullptr;
}

And our default generated data would not have "move ctor". After changed to movable, the performance has 30% optimizations.

Component(s)

C++, Parquet

[mapleFU]

A POC can be seen here main...mapleFU:arrow:parquet/thrift-gen-movable

@wgtmac @emkornfield @pitrou would you think this is ok?

[wgtmac]

Is there any dependency on the tool chain? If not, we should probably enable it by default.

[mapleFU]

I think it's introduced in apache/thrift@3c5a788 . It's introduced so many years ago in 0.9.3

[pitrou]

+1

[mapleFU]

I've draft a patch here: #37461