Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] CRAN failures due to "invalid non-character version specification" #37386

Closed
thisisnic opened this issue Aug 25, 2023 · 0 comments · Fixed by #37387
Closed

[R] CRAN failures due to "invalid non-character version specification" #37386

thisisnic opened this issue Aug 25, 2023 · 0 comments · Fixed by #37387
Assignees
Milestone

Comments

@thisisnic
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

  ══ Failed tests ════════════════════════════════════════════════════════════════
  ── Error ('test-data-type.R:612:3'): DataType$code() ───────────────────────────
  Error in `.make_numeric_version(x, strict, .standard_regexps()$valid_numeric_version)`: invalid non-character version specification 'x' (type: double)
  Backtrace:
      ▆
   1. ├─testthat::skip_if(packageVersion("rlang") < 1) at test-data-type.R:612:2
   2. │ └─base::isTRUE(condition)
   3. └─base::Ops.numeric_version(packageVersion("rlang"), 1)
   4. └─base::as.numeric_version(e2)
   5. └─base::numeric_version(x)
   6. └─base::.make_numeric_version(x, strict, .standard_regexps()$valid_numeric_version)
  ── Error ('test-schema.R:46:3'): Schema$code() ─────────────────────────────────
  Error in `.make_numeric_version(x, strict, .standard_regexps()$valid_numeric_version)`: invalid non-character version specification 'x' (type: double)
  Backtrace:
      ▆
   1. ├─testthat::skip_if(packageVersion("rlang") < 1) at test-schema.R:46:2
   2. │ └─base::isTRUE(condition)
   3. └─base::Ops.numeric_version(packageVersion("rlang"), 1)
   4. └─base::as.numeric_version(e2)
   5. └─base::numeric_version(x)
   6. └─base::.make_numeric_version(x, strict, .standard_regexps()$valid_numeric_version)
  
  [ FAIL 2 | WARN 8 | SKIP 127 | PASS 7057 ]
  Error: Test failures
  Execution halted

Component(s)

R

@thisisnic thisisnic self-assigned this Aug 25, 2023
thisisnic added a commit that referenced this issue Aug 25, 2023
…cification" (#37387)

### Rationale for this change

Package version comparison results in CRAN checks failing due to values being numeric not character

### What changes are included in this PR?

Changing numeric values to characters

### Are these changes tested?

No

### Are there any user-facing changes?

No
* Closes: #37386

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@thisisnic thisisnic added this to the 14.0.0 milestone Aug 25, 2023
thisisnic added a commit to thisisnic/arrow that referenced this issue Aug 25, 2023
…on specification" (apache#37387)

### Rationale for this change

Package version comparison results in CRAN checks failing due to values being numeric not character

### What changes are included in this PR?

Changing numeric values to characters

### Are these changes tested?

No

### Are there any user-facing changes?

No
* Closes: apache#37386

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
…on specification" (apache#37387)

### Rationale for this change

Package version comparison results in CRAN checks failing due to values being numeric not character

### What changes are included in this PR?

Changing numeric values to characters

### Are these changes tested?

No

### Are there any user-facing changes?

No
* Closes: apache#37386

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
szymanskir added a commit to szymanskir/szymanskir.github.io that referenced this issue Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant