Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][S3] CRT support may not be detected #37394

Closed
kou opened this issue Aug 25, 2023 · 0 comments · Fixed by #37395
Closed

[C++][S3] CRT support may not be detected #37394

kou opened this issue Aug 25, 2023 · 0 comments · Fixed by #37395
Assignees
@kou
Labels
Component: C++ Type: enhancement
Milestone
14.0.0

Comments

@kou
Copy link
Member

kou commented Aug 25, 2023

Describe the enhancement requested

See the following comments:

Component(s)

C++
@kou kou mentioned this issue Aug 25, 2023
Closed
kou added a commit to kou/arrow that referenced this issue Aug 25, 2023
@kou
apacheGH-37394: [C++][S3] Use AWS_SDK_VERSION_* instead of try_compile()
80e04a7
@github-actions github-actions bot mentioned this issue Aug 25, 2023
Merged
kou added a commit to kou/arrow that referenced this issue Aug 25, 2023
@kou
apacheGH-37394: [C++][S3] Use AWS_SDK_VERSION_* instead of try_compile()
2a39548
kou added a commit that referenced this issue Aug 30, 2023
@kou
GH-37394: [C++][S3] Use AWS_SDK_VERSION_* instead of try_compile() (#…
8ba3264 
…37395)

### Rationale for this change

I don't know why but `try_compile()` based `Aws::SDKOptions::ioOptions` detection seems not work on some environments. Some unrelated errors may be happen.

### What changes are included in this PR?

Using `AWS_SDK_VERSION_{MAJOR,MINOR,PATCH}` instead of `try_compile()`.

Downside: `AWS_SDK_VERSION_*` are available since 1.9.7 or later but `Aws::SDKOptions::ioOptions` is available since 1.9.0. So we can't detect `Aws::SDKOptions::ioOptions` with [1.9.0,1.9.6]. I think that it's acceptable.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #37394

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 14.0.0 milestone Aug 30, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@kou @loicalleyne
apacheGH-37394: [C++][S3] Use AWS_SDK_VERSION_* instead of try_compil…
690d920 
…e() (apache#37395)

### Rationale for this change

I don't know why but `try_compile()` based `Aws::SDKOptions::ioOptions` detection seems not work on some environments. Some unrelated errors may be happen.

### What changes are included in this PR?

Using `AWS_SDK_VERSION_{MAJOR,MINOR,PATCH}` instead of `try_compile()`.

Downside: `AWS_SDK_VERSION_*` are available since 1.9.7 or later but `Aws::SDKOptions::ioOptions` is available since 1.9.0. So we can't detect `Aws::SDKOptions::ioOptions` with [1.9.0,1.9.6]. I think that it's acceptable.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#37394

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@kou @dgreiss
apacheGH-37394: [C++][S3] Use AWS_SDK_VERSION_* instead of try_compil…
fb175d2 
…e() (apache#37395)

### Rationale for this change

I don't know why but `try_compile()` based `Aws::SDKOptions::ioOptions` detection seems not work on some environments. Some unrelated errors may be happen.

### What changes are included in this PR?

Using `AWS_SDK_VERSION_{MAJOR,MINOR,PATCH}` instead of `try_compile()`.

Downside: `AWS_SDK_VERSION_*` are available since 1.9.7 or later but `Aws::SDKOptions::ioOptions` is available since 1.9.0. So we can't detect `Aws::SDKOptions::ioOptions` with [1.9.0,1.9.6]. I think that it's acceptable.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#37394

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37394: [C++][S3] Use AWS_SDK_VERSION_* instead of try_compile() kou/arrow
1 participant
@kou