[C++][FlightRPC] ArrowFlightSql::arrow_flight_sql_{shared,static} doesn't depend on ArrowFlight::arrow_flight_{shared,static} #37406
Comments
kou
added a commit
to kou/arrow
that referenced
this issue
Aug 27, 2023
…t_{shared,static} dependencies
lidavidm
pushed a commit
that referenced
this issue
Aug 28, 2023
…red,static} dependencies (#37407) ### Rationale for this change `ArrowFlightSql::arrow_flight_sql_shared` must depend on `ArrowFlight::arrow_flight_shared` because `arrow/flight/sql/*.h` uses ` arrow/flight/*.h` and all users must use Flight RPC API with Flight SQL API. ### What changes are included in this PR? Add missing `{SHARED,STATIC}_INSTALL_INTERFACE_LIBS`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: #37406 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: David Li <li.davidm96@gmail.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
…t_{shared,static} dependencies (apache#37407)
### Rationale for this change
`ArrowFlightSql::arrow_flight_sql_shared` must depend on `ArrowFlight::arrow_flight_shared` because `arrow/flight/sql/*.h` uses ` arrow/flight/*.h` and all users must use Flight RPC API with Flight SQL API.
### What changes are included in this PR?
Add missing `{SHARED,STATIC}_INSTALL_INTERFACE_LIBS`.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
* Closes: apache#37406
Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
ArrowFlightSql::arrow_flight_sql_sharedmust depend onArrowFlight::arrow_flight_sharedbecausearrow/flight/sql/*.husesarrow/flight/*.hand all users must use Flight RPC API with Flight SQL API.Component(s)
C++, FlightRPC
The text was updated successfully, but these errors were encountered: