Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Arrow to parquet conversion fails for arrow.DECIMAL256 type #37419

Closed
k-anshul opened this issue Aug 28, 2023 · 1 comment · Fixed by #37503
Closed

[Go] Arrow to parquet conversion fails for arrow.DECIMAL256 type #37419

k-anshul opened this issue Aug 28, 2023 · 1 comment · Fixed by #37503
Assignees
@zeroshade
Labels
Component: Go Type: bug
Milestone
14.0.0

Comments

@k-anshul
Copy link

Describe the bug, including details regarding any error messages, version, and platform.

Details : The arrow to parquet conversion fails for arrow.DECIMAL256 type with error err not implemented: support for DECIMAL256
Haven't looked at the internal details but seems like it may have been missed while introducing support for arrow.DECIMAL256 type here : #13792

Version : v13
Platform : macOS M1

Component(s)

Go
@k-anshul k-anshul changed the title Arrow to parquet conversion fails for arrow.DECIMAL256 type [Go] Arrow to parquet conversion fails for arrow.DECIMAL256 type Aug 28, 2023
@k-anshul k-anshul mentioned this issue Aug 28, 2023
Open
@zeroshade
Copy link
Member

I've started working on this

@zeroshade zeroshade self-assigned this Aug 30, 2023
@github-actions github-actions bot mentioned this issue Aug 31, 2023
Merged
zeroshade added a commit that referenced this issue Sep 5, 2023
@zeroshade
GH-37419: [Go][Parquet] Decimal256 support for pqarrow (#37503)
697a2cb 
### Rationale for this change
When support for decimal128 was added to the Go Parquet lib, decimal256 wasn't yet implemented in the library. This adds proper support to read/write decimal256 with Parquet based on origin schemas and precision.

### Are these changes tested?
yes

* Closes: #37419

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 14.0.0 milestone Sep 5, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@zeroshade @loicalleyne
apacheGH-37419: [Go][Parquet] Decimal256 support for pqarrow (apache#…
b9efba5 
…37503)

### Rationale for this change
When support for decimal128 was added to the Go Parquet lib, decimal256 wasn't yet implemented in the library. This adds proper support to read/write decimal256 with Parquet based on origin schemas and precision.

### Are these changes tested?
yes

* Closes: apache#37419

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@zeroshade @dgreiss
apacheGH-37419: [Go][Parquet] Decimal256 support for pqarrow (apache#…
52404be 
…37503)

### Rationale for this change
When support for decimal128 was added to the Go Parquet lib, decimal256 wasn't yet implemented in the library. This adds proper support to read/write decimal256 with Parquet based on origin schemas and precision.

### Are these changes tested?
yes

* Closes: apache#37419

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeroshade zeroshade

Labels
Component: Go Type: bug
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37419: [Go][Parquet] Decimal256 support for pqarrow zeroshade/arrow
2 participants
@zeroshade @k-anshul