Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R][CI] Nightly CI jobs failing with Thrift error #37535

Closed
thisisnic opened this issue Sep 4, 2023 · 5 comments · Fixed by #37603
Closed

[R][CI] Nightly CI jobs failing with Thrift error #37535

thisisnic opened this issue Sep 4, 2023 · 5 comments · Fixed by #37603
Assignees
@kou
Labels
Component: R Type: bug
Milestone
14.0.0

Comments

@thisisnic
Copy link
Member

thisisnic commented Sep 4, 2023 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

Multiple nightly CI jobs, including test-r-depsource-system and test-r-dev-duckdb are failing with a Thrift error:

e.g.

Error: package or namespace load failed for ‘arrow’ in dyn.load(file, DLLpath = DLLpath, ...):
 unable to load shared object '/arrow/r/check/arrow.Rcheck/00LOCK-arrow/00new/arrow/libs/arrow.so':
  /arrow/r/check/arrow.Rcheck/00LOCK-arrow/00new/arrow/libs/arrow.so: undefined symbol: _ZTIN6apache6thrift8protocol9TProtocolE
Error: loading failed
Execution halted
ERROR: loading failed
* removing ‘/arrow/r/check/arrow.Rcheck/arrow’

Failing jobs:

  • test-r-depsource-system
  • test-r-dev-duckdb
  • test-r-gcc11
  • test-r-gcc-12
  • test-r-rhub-ubuntu-22.04

Component(s)

R
@thisisnic thisisnic changed the title [R][CI] Nightly CI job test-r-depsource-system failing with Thrift error [R][CI] Nightly CI jobs failing with Thrift error Sep 4, 2023
@thisisnic
Copy link
Member Author

I've submitted a crossbow build on one of the commits that may or may not be the cause: #37399 (comment)

@thisisnic
Copy link
Member Author

@kou Do you mind taking a look at this? I think it might be due to the changes in #37399 as the nightly builds started failing after this point

@kou
Copy link
Member

kou commented Sep 7, 2023

Oh, sorry.
I'll take a look at this.

kou added a commit to kou/arrow that referenced this issue Sep 7, 2023
@kou
apacheGH-37535: [C++][Parquet] Add missing "thrift" dependency in par…
ff298c8 
…quet.pc
kou added a commit to kou/arrow that referenced this issue Sep 7, 2023
@kou
apacheGH-37535: [C++][Parquet] Add missing "thrift" dependency in par…
e69b819 
…quet.pc
@github-actions github-actions bot mentioned this issue Sep 7, 2023
Merged
@kou
Copy link
Member

kou commented Sep 7, 2023

Note that DuckDB's R bindings were moved recently: duckdb/duckdb#8793
We need to update our CI code.

@thisisnic
Copy link
Member Author

thisisnic commented Sep 7, 2023 •
edited
Loading

Note that DuckDB's R bindings were moved recently: duckdb/duckdb#8793 We need to update our CI code.

Thanks for highlighting this, I've opened #37614

kou added a commit to kou/arrow that referenced this issue Sep 8, 2023
@kou
apacheGH-37535: [C++][Parquet] Add missing "thrift" dependency in par…
0d496cd 
…quet.pc
kou added a commit that referenced this issue Sep 11, 2023
@kou
GH-37535: [C++][Parquet] Add missing "thrift" dependency in parquet.pc (
c0c56e8 
#37603)

### Rationale for this change

GH-37399 removed "thrift" pkg-config package dependency from "parquet" pkg-config package accidentally. 
Before GH-37399, "arrow" pkg-config packages has "thrift" pkg-config package dependency as `Requires.private`.

### What changes are included in this PR?

Add "thrift" to `Requires.private` of `parquet.pc`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #37535

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 14.0.0 milestone Sep 11, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@kou @loicalleyne
apacheGH-37535: [C++][Parquet] Add missing "thrift" dependency in par…
01fb1aa 
…quet.pc (apache#37603)

### Rationale for this change

apacheGH-37399 removed "thrift" pkg-config package dependency from "parquet" pkg-config package accidentally. 
Before apacheGH-37399, "arrow" pkg-config packages has "thrift" pkg-config package dependency as `Requires.private`.

### What changes are included in this PR?

Add "thrift" to `Requires.private` of `parquet.pc`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#37535

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@kou @dgreiss
apacheGH-37535: [C++][Parquet] Add missing "thrift" dependency in par…
3938019 
…quet.pc (apache#37603)

### Rationale for this change

apacheGH-37399 removed "thrift" pkg-config package dependency from "parquet" pkg-config package accidentally. 
Before apacheGH-37399, "arrow" pkg-config packages has "thrift" pkg-config package dependency as `Requires.private`.

### What changes are included in this PR?

Add "thrift" to `Requires.private` of `parquet.pc`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#37535

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: R Type: bug
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37535: [C++][Parquet] Add missing "thrift" dependency in parquet.pc kou/arrow
2 participants
@kou @thisisnic