Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][C++] test-ubuntu-20.04-cpp-minimal-with-formats failed #37601

Closed
kou opened this issue Sep 7, 2023 · 0 comments · Fixed by #37602
Closed

[CI][C++] test-ubuntu-20.04-cpp-minimal-with-formats failed #37601

kou opened this issue Sep 7, 2023 · 0 comments · Fixed by #37602
Assignees
@kou
Labels
Component: C++ Component: Continuous Integration Type: bug
Milestone
14.0.0

Comments

@kou
Copy link
Member

kou commented Sep 7, 2023

Describe the bug, including details regarding any error messages, version, and platform.

https://github.com/ursacomputing/crossbow/actions/runs/6099155746/job/16551111386#step:6:1592

 [ 92%] Building CXX object src/parquet/CMakeFiles/parquet-file-deserialize-test.dir/file_deserialize_test.cc.o
/arrow/cpp/src/parquet/file_deserialize_test.cc:18:10: fatal error: gmock/gmock.h: No such file or directory
   18 | #include <gmock/gmock.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.

Component(s)

C++, Continuous Integration
@kou kou added the Type: bug label Sep 7, 2023
@kou kou mentioned this issue Sep 7, 2023
Merged
kou added a commit to kou/arrow that referenced this issue Sep 7, 2023
@kou
apacheGH-37601: [C++][Parquet] Add missing GoogleMock dependency
cc16bba
@github-actions github-actions bot mentioned this issue Sep 7, 2023
Merged
@kou kou closed this as completed in #37602 Sep 7, 2023
kou added a commit that referenced this issue Sep 7, 2023
@kou
GH-37601: [C++][Parquet] Add missing GoogleMock dependency (#37602)
b06e3ad 
### Rationale for this change

Parquet's tests uses GoogleMock. So we should specify GoogleMock as a dependency explicitly.

### What changes are included in this PR?

Add `${ARROW_GTEST_GMOCK}` to `PARQUET_MIN_TEST_LIBS`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #37601

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 14.0.0 milestone Sep 7, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@kou @loicalleyne
apacheGH-37601: [C++][Parquet] Add missing GoogleMock dependency (apa…
0fa6634 
…che#37602)

### Rationale for this change

Parquet's tests uses GoogleMock. So we should specify GoogleMock as a dependency explicitly.

### What changes are included in this PR?

Add `${ARROW_GTEST_GMOCK}` to `PARQUET_MIN_TEST_LIBS`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#37601

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@kou @dgreiss
apacheGH-37601: [C++][Parquet] Add missing GoogleMock dependency (apa…
6e6942a 
…che#37602)

### Rationale for this change

Parquet's tests uses GoogleMock. So we should specify GoogleMock as a dependency explicitly.

### What changes are included in this PR?

Add `${ARROW_GTEST_GMOCK}` to `PARQUET_MIN_TEST_LIBS`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#37601

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Component: Continuous Integration Type: bug
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37601: [C++][Parquet] Add missing GoogleMock dependency kou/arrow
1 participant
@kou