Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] [Benchmarking] JavaScript microbenchmarks are failing #37657

Closed
austin3dickey opened this issue Sep 11, 2023 · 3 comments · Fixed by #38500
Closed

[JS] [Benchmarking] JavaScript microbenchmarks are failing #37657

austin3dickey opened this issue Sep 11, 2023 · 3 comments · Fixed by #38500

Comments

@austin3dickey
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

Since this PR:

the JavaScript microbenchmarks have been failing on our Ubuntu runner. Here is an example build: https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/3550#018a82a7-0b90-4c4b-99fd-c6be4b453e85/6-24091

['yarn', 'perf', '--json']
(node:2507379) ExperimentalWarning: Custom ESM Loaders is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
ReferenceError: exports is not defined in ES module scope
    at file:///var/lib/buildkite-agent/builds/ursa-i9-9960x-2/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/arrow/js/perf/index.ts:18:23
    at ModuleJob.run (node:internal/modules/esm/module_job:198:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:409:24)
    at async loadESM (node:internal/process/esm_loader:85:5)
    at async handleMainPromise (node:internal/modules/run_main:61:12)
error Command failed with exit code 1.

Component(s)

Benchmarking, JavaScript

@austin3dickey
Copy link
Contributor Author

FYI @trxcllnt @domoritz

assignUser added a commit that referenced this issue Nov 2, 2023
(rebased version of #37668, yarn.lock conflicts resolved in favor of main)
* update bin scripts to use ts-node in transpile-only mode
* remove ts-node config from top level tsconfig.json
* fix tsc errors in bin scripts
* Closes: #37657

Authored-by: ptaylor <paul.e.taylor@me.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@assignUser assignUser added this to the 15.0.0 milestone Nov 2, 2023
@austin3dickey
Copy link
Contributor Author

Thanks @assignUser ! Right now the only machine that runs JS benchmarks is offline but once it comes back on I'm excited to test this.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
(rebased version of apache#37668, yarn.lock conflicts resolved in favor of main)
* update bin scripts to use ts-node in transpile-only mode
* remove ts-node config from top level tsconfig.json
* fix tsc errors in bin scripts
* Closes: apache#37657

Authored-by: ptaylor <paul.e.taylor@me.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@austin3dickey
Copy link
Contributor Author

Confirmed the JS benchmarks are working again. 💜

dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
(rebased version of apache#37668, yarn.lock conflicts resolved in favor of main)
* update bin scripts to use ts-node in transpile-only mode
* remove ts-node config from top level tsconfig.json
* fix tsc errors in bin scripts
* Closes: apache#37657

Authored-by: ptaylor <paul.e.taylor@me.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment