Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go][Benchmarking] Update usage of benchadapt in Go benchmarks #37771

Closed
austin3dickey opened this issue Sep 18, 2023 · 0 comments · Fixed by #37772
Closed

[Go][Benchmarking] Update usage of benchadapt in Go benchmarks #37771

austin3dickey opened this issue Sep 18, 2023 · 0 comments · Fixed by #37772
Assignees
@austin3dickey
Labels
Component: Benchmarking Component: Go Type: bug
Milestone
14.0.0

Comments

@austin3dickey
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

With the new Conbench server version and benchadapt client version, we need to update github_commit_info to always be a dict with a repository key:

arrow/ci/scripts/go_bench_adapt.py

Line 38 in a7f5ee0

github_commit_info: Optional[Dict] = None

Component(s)

Benchmarking, Go
@austin3dickey austin3dickey mentioned this issue Sep 18, 2023
Merged
zeroshade pushed a commit that referenced this issue Sep 18, 2023
@austin3dickey
GH-37771: [Go][Benchmarking] Update Conbench git info (#37772)
efbabd3 
This PR fixes the Go benchmarking script to comply with the new Conbench server and client versions. Fixes #37771.
* Closes: #37771

Authored-by: Austin Dickey <austin3spammy@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 14.0.0 milestone Sep 18, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@austin3dickey @loicalleyne
apacheGH-37771: [Go][Benchmarking] Update Conbench git info (apache#3…
a67a448 
…7772)

This PR fixes the Go benchmarking script to comply with the new Conbench server and client versions. Fixes apache#37771.
* Closes: apache#37771

Authored-by: Austin Dickey <austin3spammy@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@austin3dickey @dgreiss
apacheGH-37771: [Go][Benchmarking] Update Conbench git info (apache#3…
cf4509d 
…7772)

This PR fixes the Go benchmarking script to comply with the new Conbench server and client versions. Fixes apache#37771.
* Closes: apache#37771

Authored-by: Austin Dickey <austin3spammy@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@austin3dickey austin3dickey

Labels
Component: Benchmarking Component: Go Type: bug
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37771: [Go][Benchmarking] Update Conbench git info austin3dickey/arrow
2 participants
@zeroshade @austin3dickey