Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Integration][Go] Implement Go C Data Interface integration testing #37789

Closed
pitrou opened this issue Sep 19, 2023 · 0 comments · Fixed by #37788
Closed

[Integration][Go] Implement Go C Data Interface integration testing #37789

pitrou opened this issue Sep 19, 2023 · 0 comments · Fixed by #37788
Assignees
@pitrou
Labels
Component: Go Component: Integration Type: enhancement
Milestone
14.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Sep 19, 2023

Describe the enhancement requested

Now that we have an infrastructure for integration testing of the C Data Interface (gh-37537), we should add an implementation for Go Arrow.

Component(s)

Go, Integration
@github-actions github-actions bot mentioned this issue Sep 19, 2023
Merged
pitrou added a commit to pitrou/arrow that referenced this issue Sep 19, 2023
@pitrou
apacheGH-37789: [Integration][Go] Go C Data Interface integration tes…
365abee 
…ting
pitrou added a commit to pitrou/arrow that referenced this issue Sep 20, 2023
@pitrou
apacheGH-37789: [Integration][Go] Go C Data Interface integration tes…
a4972fa 
…ting
pitrou added a commit to pitrou/arrow that referenced this issue Sep 25, 2023
@pitrou
apacheGH-37789: [Integration][Go] Go C Data Interface integration tes…
c5fc628 
…ting
@pitrou pitrou added this to the 14.0.0 milestone Sep 26, 2023
pitrou added a commit that referenced this issue Sep 26, 2023
@pitrou
GH-37789: [Integration][Go] Go C Data Interface integration testing (#…
cc51e68 
…37788)

### Rationale for this change

We want to enable integration testing of the Arrow Go implementation of the C Data Interface, so as to ensure interoperability.

### What changes are included in this PR?

1. Enable C Data Interface integration testing for the Arrow Go implementation
2. Fix compatibility issues found by the integration tests

### Are these changes tested?

Yes, by construction.

### Are there any user-facing changes?

Bugfixes in the Arrow Go C Data Interface implementation.

* Closes: #37789

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
etseidl pushed a commit to etseidl/arrow that referenced this issue Sep 28, 2023
@pitrou @etseidl
apacheGH-37789: [Integration][Go] Go C Data Interface integration tes…
072ad2e 
…ting (apache#37788)

### Rationale for this change

We want to enable integration testing of the Arrow Go implementation of the C Data Interface, so as to ensure interoperability.

### What changes are included in this PR?

1. Enable C Data Interface integration testing for the Arrow Go implementation
2. Fix compatibility issues found by the integration tests

### Are these changes tested?

Yes, by construction.

### Are there any user-facing changes?

Bugfixes in the Arrow Go C Data Interface implementation.

* Closes: apache#37789

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@pitrou
apacheGH-37789: [Integration][Go] Go C Data Interface integration tes…
74fb60b 
…ting (apache#37788)

### Rationale for this change

We want to enable integration testing of the Arrow Go implementation of the C Data Interface, so as to ensure interoperability.

### What changes are included in this PR?

1. Enable C Data Interface integration testing for the Arrow Go implementation
2. Fix compatibility issues found by the integration tests

### Are these changes tested?

Yes, by construction.

### Are there any user-facing changes?

Bugfixes in the Arrow Go C Data Interface implementation.

* Closes: apache#37789

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@pitrou @loicalleyne
apacheGH-37789: [Integration][Go] Go C Data Interface integration tes…
197a169 
…ting (apache#37788)

### Rationale for this change

We want to enable integration testing of the Arrow Go implementation of the C Data Interface, so as to ensure interoperability.

### What changes are included in this PR?

1. Enable C Data Interface integration testing for the Arrow Go implementation
2. Fix compatibility issues found by the integration tests

### Are these changes tested?

Yes, by construction.

### Are there any user-facing changes?

Bugfixes in the Arrow Go C Data Interface implementation.

* Closes: apache#37789

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@pitrou @dgreiss
apacheGH-37789: [Integration][Go] Go C Data Interface integration tes…
8fbffa4 
…ting (apache#37788)

### Rationale for this change

We want to enable integration testing of the Arrow Go implementation of the C Data Interface, so as to ensure interoperability.

### What changes are included in this PR?

1. Enable C Data Interface integration testing for the Arrow Go implementation
2. Fix compatibility issues found by the integration tests

### Are these changes tested?

Yes, by construction.

### Are there any user-facing changes?

Bugfixes in the Arrow Go C Data Interface implementation.

* Closes: apache#37789

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitrou pitrou

Labels
Component: Go Component: Integration Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37789: [Integration][Go] Go C Data Interface integration testing pitrou/arrow
1 participant
@pitrou