Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Gandiva Types.proto may conflict with other proto definition #37893

Closed
laurentgo opened this issue Sep 26, 2023 · 0 comments · Fixed by #37894
Closed

[Java] Gandiva Types.proto may conflict with other proto definition #37893

laurentgo opened this issue Sep 26, 2023 · 0 comments · Fixed by #37894
Assignees
@laurentgo
Labels
Breaking Change Includes a breaking change to the API Component: Java Type: bug
Milestone
14.0.0

Comments

@laurentgo
Copy link
Collaborator

Describe the bug, including details regarding any error messages, version, and platform.

Types.proto is a Gandiva protobuf definition used by Gandiva to exchange data between Java and C++. This file is packaged automatically within arrow-gandiva jar by protobuf-maven-plugin but because of its generic name, it may cause conflicts in others' people project who also use Types.proto.

Ideally the file should be put into some subdirectory (gandiva for example) and people referencing it in their own project should use import "gandiva/Types.proto' instead of import "Types.proto"`.

Component(s)

Java
laurentgo added a commit to laurentgo/arrow that referenced this issue Sep 26, 2023
@laurentgo
apacheGH-37893: [Java] Move Types.proto in a subfolder
5a65f79 
Types.proto is a Gandiva protobuf definition used by Gandiva to exchange
data between Java and C++. This file is packaged automatically within
arrow-gandiva jar but because of its generic name, it may cause
conflicts in others' people project.

Move Types.proto into gandiva/types.proto (also matching convention of
using lowercase filename) so that it become less likely to cause a
conflict.
@github-actions github-actions bot mentioned this issue Sep 26, 2023
Merged
@lidavidm lidavidm added the Breaking Change Includes a breaking change to the API label Sep 26, 2023
lidavidm pushed a commit that referenced this issue Sep 28, 2023
@laurentgo
GH-37893: [Java] Move Types.proto in a subfolder (#37894)
019d06d 
### Rationale for this change

Types.proto is a Gandiva protobuf definition used by Gandiva to exchange data between Java and C++. This file is packaged automatically within arrow-gandiva jar but because of its generic name, it may cause conflicts in others' people project.

### What changes are included in this PR?

Move `Types.proto` into `gandiva/types.proto` (also matching convention of using lowercase filename) so that it become less likely to cause a conflict.

### Are these changes tested?

Change should have no impact on the feature itself. Manually check the resulting jar to confirm that `types.proto` is not located at the root of the archive.

### Are there any user-facing changes?

No user-facing. Developers who were actually referencing Gandiva `Types.proto` in their project may have to change their `import` directive.

**This PR includes breaking changes to public APIs.**

* Closes: #37893

Authored-by: Laurent Goujon <laurent@apache.org>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 14.0.0 milestone Sep 28, 2023
etseidl pushed a commit to etseidl/arrow that referenced this issue Sep 28, 2023
@laurentgo @etseidl
apacheGH-37893: [Java] Move Types.proto in a subfolder (apache#37894)
180b5be 
### Rationale for this change

Types.proto is a Gandiva protobuf definition used by Gandiva to exchange data between Java and C++. This file is packaged automatically within arrow-gandiva jar but because of its generic name, it may cause conflicts in others' people project.

### What changes are included in this PR?

Move `Types.proto` into `gandiva/types.proto` (also matching convention of using lowercase filename) so that it become less likely to cause a conflict.

### Are these changes tested?

Change should have no impact on the feature itself. Manually check the resulting jar to confirm that `types.proto` is not located at the root of the archive.

### Are there any user-facing changes?

No user-facing. Developers who were actually referencing Gandiva `Types.proto` in their project may have to change their `import` directive.

**This PR includes breaking changes to public APIs.**

* Closes: apache#37893

Authored-by: Laurent Goujon <laurent@apache.org>
Signed-off-by: David Li <li.davidm96@gmail.com>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@laurentgo
apacheGH-37893: [Java] Move Types.proto in a subfolder (apache#37894)
52953c7 
### Rationale for this change

Types.proto is a Gandiva protobuf definition used by Gandiva to exchange data between Java and C++. This file is packaged automatically within arrow-gandiva jar but because of its generic name, it may cause conflicts in others' people project.

### What changes are included in this PR?

Move `Types.proto` into `gandiva/types.proto` (also matching convention of using lowercase filename) so that it become less likely to cause a conflict.

### Are these changes tested?

Change should have no impact on the feature itself. Manually check the resulting jar to confirm that `types.proto` is not located at the root of the archive.

### Are there any user-facing changes?

No user-facing. Developers who were actually referencing Gandiva `Types.proto` in their project may have to change their `import` directive.

**This PR includes breaking changes to public APIs.**

* Closes: apache#37893

Authored-by: Laurent Goujon <laurent@apache.org>
Signed-off-by: David Li <li.davidm96@gmail.com>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@laurentgo
apacheGH-37893: [Java] Move Types.proto in a subfolder (apache#37894)
4834982 
### Rationale for this change

Types.proto is a Gandiva protobuf definition used by Gandiva to exchange data between Java and C++. This file is packaged automatically within arrow-gandiva jar but because of its generic name, it may cause conflicts in others' people project.

### What changes are included in this PR?

Move `Types.proto` into `gandiva/types.proto` (also matching convention of using lowercase filename) so that it become less likely to cause a conflict.

### Are these changes tested?

Change should have no impact on the feature itself. Manually check the resulting jar to confirm that `types.proto` is not located at the root of the archive.

### Are there any user-facing changes?

No user-facing. Developers who were actually referencing Gandiva `Types.proto` in their project may have to change their `import` directive.

**This PR includes breaking changes to public APIs.**

* Closes: apache#37893

Authored-by: Laurent Goujon <laurent@apache.org>
Signed-off-by: David Li <li.davidm96@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@laurentgo @loicalleyne
apacheGH-37893: [Java] Move Types.proto in a subfolder (apache#37894)
1024ae7 
### Rationale for this change

Types.proto is a Gandiva protobuf definition used by Gandiva to exchange data between Java and C++. This file is packaged automatically within arrow-gandiva jar but because of its generic name, it may cause conflicts in others' people project.

### What changes are included in this PR?

Move `Types.proto` into `gandiva/types.proto` (also matching convention of using lowercase filename) so that it become less likely to cause a conflict.

### Are these changes tested?

Change should have no impact on the feature itself. Manually check the resulting jar to confirm that `types.proto` is not located at the root of the archive.

### Are there any user-facing changes?

No user-facing. Developers who were actually referencing Gandiva `Types.proto` in their project may have to change their `import` directive.

**This PR includes breaking changes to public APIs.**

* Closes: apache#37893

Authored-by: Laurent Goujon <laurent@apache.org>
Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@laurentgo @dgreiss
apacheGH-37893: [Java] Move Types.proto in a subfolder (apache#37894)
e476daf 
### Rationale for this change

Types.proto is a Gandiva protobuf definition used by Gandiva to exchange data between Java and C++. This file is packaged automatically within arrow-gandiva jar but because of its generic name, it may cause conflicts in others' people project.

### What changes are included in this PR?

Move `Types.proto` into `gandiva/types.proto` (also matching convention of using lowercase filename) so that it become less likely to cause a conflict.

### Are these changes tested?

Change should have no impact on the feature itself. Manually check the resulting jar to confirm that `types.proto` is not located at the root of the archive.

### Are there any user-facing changes?

No user-facing. Developers who were actually referencing Gandiva `Types.proto` in their project may have to change their `import` directive.

**This PR includes breaking changes to public APIs.**

* Closes: apache#37893

Authored-by: Laurent Goujon <laurent@apache.org>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurentgo laurentgo

Labels
Breaking Change Includes a breaking change to the API Component: Java Type: bug
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37893: [Java] Move Types.proto in a subfolder laurentgo/arrow
2 participants
@lidavidm @laurentgo