Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] tests fail on R < 4.0 due to test calling data.frame() without specifying stringsAsFactors=FALSE #37950

Closed
thisisnic opened this issue Sep 29, 2023 · 0 comments · Fixed by #37951
Closed

[R] tests fail on R < 4.0 due to test calling data.frame() without specifying stringsAsFactors=FALSE #37950

thisisnic opened this issue Sep 29, 2023 · 0 comments · Fixed by #37951
Assignees
@thisisnic
Labels
Component: R Priority: Blocker Marks a blocker for the release Type: bug
Milestone
14.0.0

Comments

@thisisnic
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

e.g. https://github.com/ursacomputing/crossbow/actions/runs/6345649167/job/17237986129#step:6:23961

══ Failed tests ════════════════════════════════════════════════════════════════
── Failure ('test-schema.R:303:3'): schema extraction ──────────────────────────
schema(data.frame(a = 1, a = "x", check.names = FALSE)) == schema(a = double(), a = string()) is not TRUE

`actual`:   FALSE
`expected`: TRUE 
Backtrace:
    ▆
 1. └─arrow:::expect_equal(...) at test-schema.R:303:2
 2.   └─testthat::expect_true(...) at tests/testthat/helper-expectation.R:37:4

Component(s)

R
@thisisnic thisisnic self-assigned this Sep 29, 2023
@github-actions github-actions bot mentioned this issue Sep 29, 2023
Merged
@thisisnic thisisnic added the Priority: Blocker Marks a blocker for the release label Sep 29, 2023
thisisnic added a commit that referenced this issue Sep 29, 2023
@thisisnic
GH-37950: [R] tests fail on R < 4.0 due to test calling data.frame() …
1415598 
…without specifying stringsAsFactors=FALSE (#37951)

### Rationale for this change

Tests failing on R < 4.0 builds due to the default value of the the `data.frame()` parameter `stringsAsFactors` between older and newer versions of R

### What changes are included in this PR?

Update a test using `data.frame()` to manually specify the value of `stringsAsFactors` as `FALSE`.

### Are these changes tested?

No

### Are there any user-facing changes?

No
* Closes: #37950

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@thisisnic thisisnic added this to the 14.0.0 milestone Sep 29, 2023
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@thisisnic
apacheGH-37950: [R] tests fail on R < 4.0 due to test calling data.fr…
d255102 
…ame() without specifying stringsAsFactors=FALSE (apache#37951)

### Rationale for this change

Tests failing on R < 4.0 builds due to the default value of the the `data.frame()` parameter `stringsAsFactors` between older and newer versions of R

### What changes are included in this PR?

Update a test using `data.frame()` to manually specify the value of `stringsAsFactors` as `FALSE`.

### Are these changes tested?

No

### Are there any user-facing changes?

No
* Closes: apache#37950

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@thisisnic
apacheGH-37950: [R] tests fail on R < 4.0 due to test calling data.fr…
61ca7d6 
…ame() without specifying stringsAsFactors=FALSE (apache#37951)

### Rationale for this change

Tests failing on R < 4.0 builds due to the default value of the the `data.frame()` parameter `stringsAsFactors` between older and newer versions of R

### What changes are included in this PR?

Update a test using `data.frame()` to manually specify the value of `stringsAsFactors` as `FALSE`.

### Are these changes tested?

No

### Are there any user-facing changes?

No
* Closes: apache#37950

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@thisisnic @loicalleyne
apacheGH-37950: [R] tests fail on R < 4.0 due to test calling data.fr…
8cae211 
…ame() without specifying stringsAsFactors=FALSE (apache#37951)

### Rationale for this change

Tests failing on R < 4.0 builds due to the default value of the the `data.frame()` parameter `stringsAsFactors` between older and newer versions of R

### What changes are included in this PR?

Update a test using `data.frame()` to manually specify the value of `stringsAsFactors` as `FALSE`.

### Are these changes tested?

No

### Are there any user-facing changes?

No
* Closes: apache#37950

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@thisisnic @dgreiss
apacheGH-37950: [R] tests fail on R < 4.0 due to test calling data.fr…
61d94bc 
…ame() without specifying stringsAsFactors=FALSE (apache#37951)

### Rationale for this change

Tests failing on R < 4.0 builds due to the default value of the the `data.frame()` parameter `stringsAsFactors` between older and newer versions of R

### What changes are included in this PR?

Update a test using `data.frame()` to manually specify the value of `stringsAsFactors` as `FALSE`.

### Are these changes tested?

No

### Are there any user-facing changes?

No
* Closes: apache#37950

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisisnic thisisnic

Labels
Component: R Priority: Blocker Marks a blocker for the release Type: bug
Projects
None yet
Milestone
14.0.0
1 participant
@thisisnic