Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Java] java-nightly cache has 8.6 GB #37971

Closed
kou opened this issue Oct 1, 2023 · 3 comments · Fixed by #37980
Closed

[CI][Java] java-nightly cache has 8.6 GB #37971

kou opened this issue Oct 1, 2023 · 3 comments · Fixed by #37980

Comments

@kou
Copy link
Member

kou commented Oct 1, 2023

Describe the enhancement requested

https://github.com/apache/arrow/actions/caches

java-nightly-6371112382
8.6 GB cached hours ago

We can use 10 GB in apache/arrow for cache. If the java-nightly cache uses 8.6 GB, other caches will be expired soon.

The java-nightly cache was introduced by GH-13839.

Component(s)

Continuous Integration, Java

@kou
Copy link
Member Author

kou commented Oct 1, 2023

@davisusanibar @assignUser @raulcd Can we just remove the java-nightly cache?

diff --git a/.github/workflows/java_nightly.yml b/.github/workflows/java_nightly.yml
index 4440d36d1..41843d663 100644
--- a/.github/workflows/java_nightly.yml
+++ b/.github/workflows/java_nightly.yml
@@ -73,12 +73,6 @@ jobs:
           fi
           echo $PREFIX
           archery crossbow download-artifacts -f java-jars -t binaries  $PREFIX
-      - name: Cache Repo
-        uses: actions/cache@v3
-        with:
-          path: repo
-          key: java-nightly-${{ github.run_id }}
-          restore-keys: java-nightly
       - name: Sync from Remote
         uses: ./arrow/.github/actions/sync-nightlies
         with:

@assignUser
Copy link
Member

Huh, looks like they are enforcing that limit now... for a long time we had around 60G of caches ^^ well we will have to download the full repo from nightlies.apache.org everytime... maybe we can find a better way to remove the old artifacts?

kou added a commit to kou/arrow that referenced this issue Oct 2, 2023
It's too large (8.6 GB) and it's always re-created because it uses
github.run_id for key. It expires other caches soon.
@kou
Copy link
Member Author

kou commented Oct 2, 2023

How about removing the actions/cache as the first step? GH-37980
Because it slows down all other CI jobs.

We can improve our uploading/pruning nightlies algorithm as the next step (with a separated issue).
For example:

  • We can upload new nightly artifacts without downloading the existing nightly artifacts.
  • We can determine old nightly artifacts to be pruned only with directories. (We don't need to download each .jar files.)
  • We can prune the target nightly artifacts by rsync --delete with local empty directory.

@kou kou closed this as completed in #37980 Oct 3, 2023
kou added a commit that referenced this issue Oct 3, 2023
### Rationale for this change

It's too large (8.6 GB) and it's always re-created because it uses github.run_id for key. It expires other caches soon.

### What changes are included in this PR?

Remove actions/cache.

### Are these changes tested?

No.

### Are there any user-facing changes?

No.
* Closes: #37971

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 14.0.0 milestone Oct 3, 2023
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
…#37980)

### Rationale for this change

It's too large (8.6 GB) and it's always re-created because it uses github.run_id for key. It expires other caches soon.

### What changes are included in this PR?

Remove actions/cache.

### Are these changes tested?

No.

### Are there any user-facing changes?

No.
* Closes: apache#37971

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
…#37980)

### Rationale for this change

It's too large (8.6 GB) and it's always re-created because it uses github.run_id for key. It expires other caches soon.

### What changes are included in this PR?

Remove actions/cache.

### Are these changes tested?

No.

### Are there any user-facing changes?

No.
* Closes: apache#37971

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
…#37980)

### Rationale for this change

It's too large (8.6 GB) and it's always re-created because it uses github.run_id for key. It expires other caches soon.

### What changes are included in this PR?

Remove actions/cache.

### Are these changes tested?

No.

### Are there any user-facing changes?

No.
* Closes: apache#37971

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
…#37980)

### Rationale for this change

It's too large (8.6 GB) and it's always re-created because it uses github.run_id for key. It expires other caches soon.

### What changes are included in this PR?

Remove actions/cache.

### Are these changes tested?

No.

### Are there any user-facing changes?

No.
* Closes: apache#37971

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants