Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Create wrapper functions for the CSV*Options classes #37994

Closed
thisisnic opened this issue Oct 3, 2023 · 0 comments · Fixed by #37995
Closed

[R] Create wrapper functions for the CSV*Options classes #37994

thisisnic opened this issue Oct 3, 2023 · 0 comments · Fixed by #37995
Assignees
@thisisnic
Labels
Component: R Type: enhancement
Milestone
14.0.0

Comments

@thisisnic
Copy link
Member

Describe the enhancement requested

As discussed in #37908

Component(s)

R
@github-actions github-actions bot mentioned this issue Oct 3, 2023
Merged
thisisnic added a commit that referenced this issue Oct 9, 2023
@thisisnic
GH-37994: [R] Create wrapper functions for the CSV*Options classes (#…
293819c 
…37995)

### Rationale for this change

It's hard to find the docs for the R6 objects for the CSV reading/writing etc options classes

### What changes are included in this PR?

Create wrapper functions, which are more easily documented

### Are these changes tested?

Yep, I've swapped some existing tests to using the wrappers

### Are there any user-facing changes?

Yes
* Closes: #37994

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@thisisnic thisisnic added this to the 14.0.0 milestone Oct 9, 2023
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@thisisnic
apacheGH-37994: [R] Create wrapper functions for the CSV*Options clas…
167efa6 
…ses (apache#37995)

### Rationale for this change

It's hard to find the docs for the R6 objects for the CSV reading/writing etc options classes

### What changes are included in this PR?

Create wrapper functions, which are more easily documented

### Are these changes tested?

Yep, I've swapped some existing tests to using the wrappers

### Are there any user-facing changes?

Yes
* Closes: apache#37994

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@thisisnic @loicalleyne
apacheGH-37994: [R] Create wrapper functions for the CSV*Options clas…
0930974 
…ses (apache#37995)

### Rationale for this change

It's hard to find the docs for the R6 objects for the CSV reading/writing etc options classes

### What changes are included in this PR?

Create wrapper functions, which are more easily documented

### Are these changes tested?

Yep, I've swapped some existing tests to using the wrappers

### Are there any user-facing changes?

Yes
* Closes: apache#37994

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@thisisnic @dgreiss
apacheGH-37994: [R] Create wrapper functions for the CSV*Options clas…
6e6e21f 
…ses (apache#37995)

### Rationale for this change

It's hard to find the docs for the R6 objects for the CSV reading/writing etc options classes

### What changes are included in this PR?

Create wrapper functions, which are more easily documented

### Are these changes tested?

Yep, I've swapped some existing tests to using the wrappers

### Are there any user-facing changes?

Yes
* Closes: apache#37994

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisisnic thisisnic

Labels
Component: R Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-37994: [R] Create wrapper functions for the CSV*Options classes thisisnic/arrow
1 participant
@thisisnic