Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][Parquet] Segfault getting compression level for a Parquet column #38039

Closed
pitrou opened this issue Oct 5, 2023 · 2 comments · Fixed by #38025
Closed

[C++][Parquet] Segfault getting compression level for a Parquet column #38039

pitrou opened this issue Oct 5, 2023 · 2 comments · Fixed by #38025
Assignees
@adamreeve
Labels
Component: C++ Component: Parquet Critical Fix Bugfixes for security vulnerabilities, crashes, or invalid data. Type: bug
Milestone
14.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Oct 5, 2023

Describe the bug, including details regarding any error messages, version, and platform.

After the changes in #35886, getting the compression level for a Parquet column segfaults if the compression level or other options weren't previously set.

Component(s)

C++, Parquet
@github-actions github-actions bot mentioned this issue Oct 5, 2023
Merged
@pitrou pitrou added this to the 14.0.0 milestone Oct 5, 2023
pitrou pushed a commit that referenced this issue Oct 5, 2023
@adamreeve
GH-38039: [C++][Parquet] Fix segfault getting compression level for a…
0fbfffb 
… Parquet column (#38025)

### Rationale for this change

After the changes in #35886, getting the compression level for a Parquet column segfaults if the compression level or other options weren't previously set

### What changes are included in this PR?

Adds a null check on the codec options of the column  properties before trying to access the compression level.

### Are these changes tested?

Yes, I added a unit test.

### Are there any user-facing changes?

This fixes a regression added after 13.0.0 so isn't a user-facing fix
* Closes: #38039

Authored-by: Adam Reeve <adreeve@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou
Copy link
Member Author

pitrou commented Oct 5, 2023

@adamreeve Can you post a comment on this issue so that we can assign to you?

@adamreeve
Copy link
Contributor

take

JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@adamreeve
apacheGH-38039: [C++][Parquet] Fix segfault getting compression level…
ca241d1 
… for a Parquet column (apache#38025)

### Rationale for this change

After the changes in apache#35886, getting the compression level for a Parquet column segfaults if the compression level or other options weren't previously set

### What changes are included in this PR?

Adds a null check on the codec options of the column  properties before trying to access the compression level.

### Are these changes tested?

Yes, I added a unit test.

### Are there any user-facing changes?

This fixes a regression added after 13.0.0 so isn't a user-facing fix
* Closes: apache#38039

Authored-by: Adam Reeve <adreeve@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@adamreeve @loicalleyne
apacheGH-38039: [C++][Parquet] Fix segfault getting compression level…
5c3b3d4 
… for a Parquet column (apache#38025)

### Rationale for this change

After the changes in apache#35886, getting the compression level for a Parquet column segfaults if the compression level or other options weren't previously set

### What changes are included in this PR?

Adds a null check on the codec options of the column  properties before trying to access the compression level.

### Are these changes tested?

Yes, I added a unit test.

### Are there any user-facing changes?

This fixes a regression added after 13.0.0 so isn't a user-facing fix
* Closes: apache#38039

Authored-by: Adam Reeve <adreeve@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@amoeba amoeba added the Critical Fix Bugfixes for security vulnerabilities, crashes, or invalid data. label Nov 17, 2023
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@adamreeve @dgreiss
apacheGH-38039: [C++][Parquet] Fix segfault getting compression level…
7ff0d80 
… for a Parquet column (apache#38025)

### Rationale for this change

After the changes in apache#35886, getting the compression level for a Parquet column segfaults if the compression level or other options weren't previously set

### What changes are included in this PR?

Adds a null check on the codec options of the column  properties before trying to access the compression level.

### Are these changes tested?

Yes, I added a unit test.

### Are there any user-facing changes?

This fixes a regression added after 13.0.0 so isn't a user-facing fix
* Closes: apache#38039

Authored-by: Adam Reeve <adreeve@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamreeve adamreeve

Labels
Component: C++ Component: Parquet Critical Fix Bugfixes for security vulnerabilities, crashes, or invalid data. Type: bug
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-38039: [C++][Parquet] Fix segfault getting compression level for a Parquet column adamreeve/arrow
3 participants
@amoeba @adamreeve @pitrou