Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go][C++] Re-generate flatbuffer sources #38053

Closed
felipecrv opened this issue Oct 5, 2023 · 0 comments · Fixed by #38054
Closed

[Go][C++] Re-generate flatbuffer sources #38053

felipecrv opened this issue Oct 5, 2023 · 0 comments · Fixed by #38054
Assignees
@felipecrv
Labels
Component: C++ Type: enhancement
Milestone
14.0.0

Comments

@felipecrv
Copy link
Contributor

Describe the enhancement requested

There are ~4 PRs depending on both string-view and list-view types that have been added to the Schema.fbs. Since generated files are checked-in, re-generating them once and for all will reduce noise in those PRs and remove the risk of conflicts (for instance, ordering of the types is significant as it affects the enum values assigned to each type).

Component(s)

C++
@github-actions github-actions bot mentioned this issue Oct 5, 2023
Merged
@pitrou pitrou added this to the 14.0.0 milestone Oct 9, 2023
@pitrou pitrou closed this as completed in d353826 Oct 9, 2023
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@felipecrv
apacheGH-38053: [C++][Go] Re-generate sources from Schema.fbs (apache…
5dc9951 
…#38054)

### Rationale for this change

Re-generate Go and C++ sources from Flatbuffers specs now including string-view and list-view types.

### What changes are included in this PR?

Documentation fixes on the .fbs files and the generated C++ and Go source files.

### Are these changes tested?

The files should be correct by construction. Existing tests guarantee that no mistake was made in re-generating the files.
* Closes: apache#38053

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@felipecrv @loicalleyne
apacheGH-38053: [C++][Go] Re-generate sources from Schema.fbs (apache…
ef62b1e 
…#38054)

### Rationale for this change

Re-generate Go and C++ sources from Flatbuffers specs now including string-view and list-view types.

### What changes are included in this PR?

Documentation fixes on the .fbs files and the generated C++ and Go source files.

### Are these changes tested?

The files should be correct by construction. Existing tests guarantee that no mistake was made in re-generating the files.
* Closes: apache#38053

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@felipecrv @dgreiss
apacheGH-38053: [C++][Go] Re-generate sources from Schema.fbs (apache…
0e9161a 
…#38054)

### Rationale for this change

Re-generate Go and C++ sources from Flatbuffers specs now including string-view and list-view types.

### What changes are included in this PR?

Documentation fixes on the .fbs files and the generated C++ and Go source files.

### Are these changes tested?

The files should be correct by construction. Existing tests guarantee that no mistake was made in re-generating the files.
* Closes: apache#38053

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipecrv felipecrv

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-38053: [C++][Go] Re-generate sources from Schema.fbs felipecrv/arrow
2 participants
@felipecrv @pitrou