Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python][CI] Fix flaky hypothesis tests #38057

Closed
danepitkin opened this issue Oct 5, 2023 · 0 comments · Fixed by #38058
Closed

[Python][CI] Fix flaky hypothesis tests #38057

danepitkin opened this issue Oct 5, 2023 · 0 comments · Fixed by #38058
Assignees
@danepitkin
Labels
Component: Continuous Integration Component: Python Priority: Blocker Marks a blocker for the release Type: bug
Milestone
14.0.0

Comments

@danepitkin
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

The following two tests are slow to generate examples. Let's suppress the warning for now, since hypothesis tests are not the bottle neck of our CI jobs.

  1. https://github.com/ursacomputing/crossbow/actions/runs/6413041834/job/17411341527
  2. https://github.com/ursacomputing/crossbow/actions/runs/6424404124/job/17444982357

Component(s)

Python
@github-actions github-actions bot mentioned this issue Oct 5, 2023
Merged
@danepitkin danepitkin changed the title [Python] Fix flaky hypothesis tests [Python][CI] Fix flaky hypothesis tests Oct 5, 2023
@danepitkin danepitkin added this to the 14.0.0 milestone Oct 5, 2023
@danepitkin danepitkin mentioned this issue Oct 5, 2023
Merged
@kou kou closed this as completed in #38058 Oct 6, 2023
kou pushed a commit that referenced this issue Oct 6, 2023
@danepitkin
GH-38057: [Python][CI] Fix flaky hypothesis tests (#38058)
bcbc707 
### Rationale for this change

Some hypothesis tests are consistently flaky due to taking too long to generate examples. "Too long" is ~2 seconds so let's just suppress the warnings. It is suppressed only for a small number of tests.

### What changes are included in this PR?

* Suppress hypothesis warnings for test data generation being too slow (> 2 seconds).

### Are these changes tested?

Will test the hypothesis CI job here.

### Are there any user-facing changes?

No
* Closes: #38057

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@danepitkin
apacheGH-38057: [Python][CI] Fix flaky hypothesis tests (apache#38058)
3786258 
### Rationale for this change

Some hypothesis tests are consistently flaky due to taking too long to generate examples. "Too long" is ~2 seconds so let's just suppress the warnings. It is suppressed only for a small number of tests.

### What changes are included in this PR?

* Suppress hypothesis warnings for test data generation being too slow (> 2 seconds).

### Are these changes tested?

Will test the hypothesis CI job here.

### Are there any user-facing changes?

No
* Closes: apache#38057

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@danepitkin @loicalleyne
apacheGH-38057: [Python][CI] Fix flaky hypothesis tests (apache#38058)
548bd5b 
### Rationale for this change

Some hypothesis tests are consistently flaky due to taking too long to generate examples. "Too long" is ~2 seconds so let's just suppress the warnings. It is suppressed only for a small number of tests.

### What changes are included in this PR?

* Suppress hypothesis warnings for test data generation being too slow (> 2 seconds).

### Are these changes tested?

Will test the hypothesis CI job here.

### Are there any user-facing changes?

No
* Closes: apache#38057

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@danepitkin @dgreiss
apacheGH-38057: [Python][CI] Fix flaky hypothesis tests (apache#38058)
8736ad2 
### Rationale for this change

Some hypothesis tests are consistently flaky due to taking too long to generate examples. "Too long" is ~2 seconds so let's just suppress the warnings. It is suppressed only for a small number of tests.

### What changes are included in this PR?

* Suppress hypothesis warnings for test data generation being too slow (> 2 seconds).

### Are these changes tested?

Will test the hypothesis CI job here.

### Are there any user-facing changes?

No
* Closes: apache#38057

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danepitkin danepitkin

Labels
Component: Continuous Integration Component: Python Priority: Blocker Marks a blocker for the release Type: bug
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-38057: [Python][CI] Fix flaky hypothesis tests danepitkin/arrow
1 participant
@danepitkin