Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Swift][CI] Add linting to CI job #38131

Closed
abandy opened this issue Oct 7, 2023 · 0 comments · Fixed by #38133
Closed

[Swift][CI] Add linting to CI job #38131

abandy opened this issue Oct 7, 2023 · 0 comments · Fixed by #38133
Assignees
@abandy
Labels
Component: Swift Type: enhancement
Milestone
15.0.0

Comments

@abandy
Copy link
Contributor

abandy commented Oct 7, 2023

Describe the enhancement requested

Currently swift doesn't include linting. The plan is to add swiftlint to docker file and run it as part of CI job as suggested #37764 (review).

Component(s)

Swift
abandy added a commit to abandy/arrow that referenced this issue Oct 7, 2023
@abandy
apacheGH-38131:Add linting to swift CI and fix linting errors
2200f51
@github-actions github-actions bot mentioned this issue Oct 7, 2023
Merged
abandy added a commit to abandy/arrow that referenced this issue Oct 7, 2023
@abandy
apacheGH-38131:Add linting to swift CI and fix linting errors
f445c56
abandy added a commit to abandy/arrow that referenced this issue Oct 8, 2023
@abandy
apacheGH-38131:Add linting to swift CI and fix linting errors
bfa3a5f
@abandy abandy mentioned this issue Oct 9, 2023
Closed
abandy added a commit to abandy/arrow that referenced this issue Oct 23, 2023
@abandy
apacheGH-38131:Add linting to swift CI and fix linting errors
095acd8
@kou kou changed the title [Swift][FlightSQL] Add linting to CI job [Swift] Add linting to CI job Oct 25, 2023
kou added a commit that referenced this issue Oct 25, 2023
@abandy @kou
GH-38131: [Swift][CI] Add linting and fix linting errors (#38133)
a449072 
Description:

- Added swiftlint to swift CI job: swift_test.sh.
- Fixed swiftlint errors in swift files.
* Closes: #38131

Lead-authored-by: Alva Bandy <abandy@live.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 15.0.0 milestone Oct 25, 2023
@kou kou changed the title [Swift] Add linting to CI job [Swift][CI] Add linting to CI job Oct 25, 2023
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 25, 2023
@abandy @kou @JerAguilon
apacheGH-38131: [Swift][CI] Add linting and fix linting errors (apach…
6cd5fb2 
…e#38133)

Description:

- Added swiftlint to swift CI job: swift_test.sh.
- Fixed swiftlint errors in swift files.
* Closes: apache#38131

Lead-authored-by: Alva Bandy <abandy@live.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@abandy @kou @loicalleyne
apacheGH-38131: [Swift][CI] Add linting and fix linting errors (apach…
8a58751 
…e#38133)

Description:

- Added swiftlint to swift CI job: swift_test.sh.
- Fixed swiftlint errors in swift files.
* Closes: apache#38131

Lead-authored-by: Alva Bandy <abandy@live.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@abandy @kou @dgreiss
apacheGH-38131: [Swift][CI] Add linting and fix linting errors (apach…
9b05504 
…e#38133)

Description:

- Added swiftlint to swift CI job: swift_test.sh.
- Fixed swiftlint errors in swift files.
* Closes: apache#38131

Lead-authored-by: Alva Bandy <abandy@live.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abandy abandy

Labels
Component: Swift Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38131: [Swift][CI] Add linting and fix linting errors abandy/arrow
2 participants
@kou @abandy