Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] version_match should match the version from versions.json #38240

Closed
AlenkaF opened this issue Oct 12, 2023 · 2 comments · Fixed by #38241
Closed

[Docs] version_match should match the version from versions.json #38240

AlenkaF opened this issue Oct 12, 2023 · 2 comments · Fixed by #38241
Assignees
@AlenkaF
Labels
Component: Documentation Type: enhancement
Milestone
14.0.0

Comments

@AlenkaF
Copy link
Member

AlenkaF commented Oct 12, 2023 •
edited

Describe the enhancement requested

To correctly display versions in the version switcher we need ro make sure version_match matches the version defined in versions.json.

Part of #37947

Component(s)

Documentation
@AlenkaF AlenkaF self-assigned this Oct 12, 2023
@AlenkaF AlenkaF mentioned this issue Oct 12, 2023
Merged
@jorisvandenbossche jorisvandenbossche added this to the 14.0.0 milestone Oct 12, 2023
@raulcd
Copy link
Member

raulcd commented Oct 16, 2023

@AlenkaF @jorisvandenbossche this is marked as 14.0.0, should this block the release?

@AlenkaF
Copy link
Member Author

AlenkaF commented Oct 16, 2023

It would be good to sort the version switcher text before the documentation is built and added to the arrow-site as I am not sure we can correct it later, if there will be a need to. But at the same time I wouldn't call it a blocker. Also I do not see a clear solution at this moment.

jorisvandenbossche pushed a commit that referenced this issue Oct 17, 2023
@AlenkaF
GH-38240: [Docs] version_match should match the version from versions…
ecd3871 
….json (#38241)

This PR corrects the version for the `version_match` to be equal to the version defined in versions.json. This way the text is correctly displayed in the version switcher button.
* Closes: #38240

Authored-by: AlenkaF <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
raulcd pushed a commit that referenced this issue Oct 17, 2023
@AlenkaF @raulcd
GH-38240: [Docs] version_match should match the version from versions…
f208e7f 
….json (#38241)

This PR corrects the version for the `version_match` to be equal to the version defined in versions.json. This way the text is correctly displayed in the version switcher button.
* Closes: #38240

Authored-by: AlenkaF <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@AlenkaF
apacheGH-38240: [Docs] version_match should match the version from ve…
ad1b78c 
…rsions.json (apache#38241)

This PR corrects the version for the `version_match` to be equal to the version defined in versions.json. This way the text is correctly displayed in the version switcher button.
* Closes: apache#38240

Authored-by: AlenkaF <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@AlenkaF @loicalleyne
apacheGH-38240: [Docs] version_match should match the version from ve…
336a3c8 
…rsions.json (apache#38241)

This PR corrects the version for the `version_match` to be equal to the version defined in versions.json. This way the text is correctly displayed in the version switcher button.
* Closes: apache#38240

Authored-by: AlenkaF <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@AlenkaF AlenkaF mentioned this issue Dec 13, 2023
Closed
2 tasks
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@AlenkaF @dgreiss
apacheGH-38240: [Docs] version_match should match the version from ve…
a32c655 
…rsions.json (apache#38241)

This PR corrects the version for the `version_match` to be equal to the version defined in versions.json. This way the text is correctly displayed in the version switcher button.
* Closes: apache#38240

Authored-by: AlenkaF <frim.alenka@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlenkaF AlenkaF

Labels
Component: Documentation Type: enhancement
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-38240: [Docs] version_match should match the version from versions.json AlenkaF/arrow
3 participants
@raulcd @jorisvandenbossche @AlenkaF