Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] RAT error for 14.0.0 RC1 source archive #38332

Closed
kou opened this issue Oct 18, 2023 · 0 comments · Fixed by #38337
Closed

[Release] RAT error for 14.0.0 RC1 source archive #38332

kou opened this issue Oct 18, 2023 · 0 comments · Fixed by #38337
Assignees
@kou
Labels
Component: Release Priority: Blocker Marks a blocker for the release Type: bug
Milestone
14.0.0

Comments

@kou
Copy link
Member

kou commented Oct 18, 2023

Describe the bug, including details regarding any error messages, version, and platform.

$ dev/release/02-source.sh 14.0.0 1
Preparing source for tag apache-arrow-14.0.0
Using commit 7a814d1de2d8f81642a5e6a795e3d716ec4981b7
NOT APPROVED: python/cmake_modules/snappy.diff (apache-arrow-14.0.0/python/cmake_modules/snappy.diff): false
1 unapproved licences. Check rat report: rat.txt

It's caused because we un-symlink python/cmake_modules/ for source archive. (See also: #4028)
We run RAT against only our repository itself not our source archive in our CI. So we can't detect this before we create RC.

Component(s)

Release
@kou kou added the Type: bug label Oct 18, 2023
kou added a commit to kou/arrow that referenced this issue Oct 19, 2023
@kou
apacheGH-38332: [CI][Release] Resolve symlinks in RAT lint
88f2fa0
@github-actions github-actions bot mentioned this issue Oct 19, 2023
Merged
@kou kou added the Priority: Blocker Marks a blocker for the release label Oct 19, 2023
@kou kou added this to the 14.0.0 milestone Oct 19, 2023
raulcd added a commit that referenced this issue Oct 19, 2023
@kou @raulcd
GH-38332: [CI][Release] Resolve symlinks in RAT lint (#38337)
3cf96b3 
### Rationale for this change

Our release script (`dev/release/02-source.sh`) resolves symlinks in source archive but our lint script (`dev/archery/archery/utils/source.py`) doesn't resolve symlinks. So we may detect RAT problem by our CI.

### What changes are included in this PR?

Resolve symlinks in our lint script too.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #38332

Lead-authored-by: Sutou Kouhei <kou@clear-code.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
raulcd added a commit that referenced this issue Oct 19, 2023
@kou @raulcd
GH-38332: [CI][Release] Resolve symlinks in RAT lint (#38337)
9f90995 
### Rationale for this change

Our release script (`dev/release/02-source.sh`) resolves symlinks in source archive but our lint script (`dev/archery/archery/utils/source.py`) doesn't resolve symlinks. So we may detect RAT problem by our CI.

### What changes are included in this PR?

Resolve symlinks in our lint script too.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #38332

Lead-authored-by: Sutou Kouhei <kou@clear-code.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Oct 23, 2023
@kou @raulcd
apacheGH-38332: [CI][Release] Resolve symlinks in RAT lint (apache#38337
a2eae17 
)

### Rationale for this change

Our release script (`dev/release/02-source.sh`) resolves symlinks in source archive but our lint script (`dev/archery/archery/utils/source.py`) doesn't resolve symlinks. So we may detect RAT problem by our CI.

### What changes are included in this PR?

Resolve symlinks in our lint script too.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38332

Lead-authored-by: Sutou Kouhei <kou@clear-code.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@kou @raulcd @loicalleyne
apacheGH-38332: [CI][Release] Resolve symlinks in RAT lint (apache#38337
e17de6d 
)

### Rationale for this change

Our release script (`dev/release/02-source.sh`) resolves symlinks in source archive but our lint script (`dev/archery/archery/utils/source.py`) doesn't resolve symlinks. So we may detect RAT problem by our CI.

### What changes are included in this PR?

Resolve symlinks in our lint script too.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38332

Lead-authored-by: Sutou Kouhei <kou@clear-code.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@kou @raulcd @dgreiss
apacheGH-38332: [CI][Release] Resolve symlinks in RAT lint (apache#38337
097d4f8 
)

### Rationale for this change

Our release script (`dev/release/02-source.sh`) resolves symlinks in source archive but our lint script (`dev/archery/archery/utils/source.py`) doesn't resolve symlinks. So we may detect RAT problem by our CI.

### What changes are included in this PR?

Resolve symlinks in our lint script too.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38332

Lead-authored-by: Sutou Kouhei <kou@clear-code.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Co-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: Release Priority: Blocker Marks a blocker for the release Type: bug
Projects
None yet
Milestone
14.0.0
Development

Successfully merging a pull request may close this issue.

GH-38332: [CI][Release] Resolve symlinks in RAT lint kou/arrow
1 participant
@kou