-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI][Release] jpype install is missing in verify-release-candidate.sh #38470
Comments
I think we should install jpype1 on the verification script too: @pitrou is there any reason why we don't install those as part of Or is it ok if I just add them there? |
They're optional for Java and C#. I don't mind adding them if they are light-weight enough to install (is it the case?). |
(why do we have release scripts with integration? should we just remove them?) |
The jpype1 binaries are available for a limited set of platforms, so I don't think we should make it mandatory to run integration tests: Conversely, pythonnet is pure Python and only depends on cffi, so I would be ok adding it to |
This should probably be fixed for the release if we want to run the integration tests. Currently nightly verification is failing for: |
… integration tests (#39502) Integration verification tasks are currently failing on CI. Install jpype and build JNI c-data to run integration tests Yes via archery No * Closes: #38470 Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…to run integration tests (apache#39502) ### Rationale for this change Integration verification tasks are currently failing on CI. ### What changes are included in this PR? Install jpype and build JNI c-data to run integration tests ### Are these changes tested? Yes via archery ### Are there any user-facing changes? No * Closes: apache#38470 Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…to run integration tests (apache#39502) ### Rationale for this change Integration verification tasks are currently failing on CI. ### What changes are included in this PR? Install jpype and build JNI c-data to run integration tests ### Are these changes tested? Yes via archery ### Are there any user-facing changes? No * Closes: apache#38470 Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…to run integration tests (apache#39502) ### Rationale for this change Integration verification tasks are currently failing on CI. ### What changes are included in this PR? Install jpype and build JNI c-data to run integration tests ### Are these changes tested? Yes via archery ### Are there any user-facing changes? No * Closes: apache#38470 Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…to run integration tests (apache#39502) ### Rationale for this change Integration verification tasks are currently failing on CI. ### What changes are included in this PR? Install jpype and build JNI c-data to run integration tests ### Are these changes tested? Yes via archery ### Are there any user-facing changes? No * Closes: apache#38470 Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Describe the bug, including details regarding any error messages, version, and platform.
verify-rc-source-integration-linux-almalinux-8-amd64:
https://github.com/ursacomputing/crossbow/actions/runs/6640611168/job/18041368451#step:6:77555
#38248 may be related.
Component(s)
Continuous Integration, Release
The text was updated successfully, but these errors were encountered: