Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Release] jpype install is missing in verify-release-candidate.sh #38470

Closed
kou opened this issue Oct 25, 2023 · 5 comments · Fixed by #39502
Closed

[CI][Release] jpype install is missing in verify-release-candidate.sh #38470

kou opened this issue Oct 25, 2023 · 5 comments · Fixed by #39502

Comments

@kou
Copy link
Member

kou commented Oct 25, 2023

Describe the bug, including details regarding any error messages, version, and platform.

verify-rc-source-integration-linux-almalinux-8-amd64:

https://github.com/ursacomputing/crossbow/actions/runs/6640611168/job/18041368451#step:6:77555

======================================================================
Testing C ArrowArray from file 'map_non_canonical'
... with record batch #0
======================================================================
Traceback (most recent call last):
  File "/tmp/arrow-HEAD.7rcH0/venv-source/bin/archery", line 8, in <module>
    sys.exit(archery())
  File "/tmp/arrow-HEAD.7rcH0/venv-source/lib64/python3.8/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/tmp/arrow-HEAD.7rcH0/venv-source/lib64/python3.8/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/tmp/arrow-HEAD.7rcH0/venv-source/lib64/python3.8/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/tmp/arrow-HEAD.7rcH0/venv-source/lib64/python3.8/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/tmp/arrow-HEAD.7rcH0/venv-source/lib64/python3.8/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/arrow/dev/archery/archery/cli.py", line 787, in integration
    run_all_tests(**args)
  File "/arrow/dev/archery/archery/integration/runner.py", line 638, in run_all_tests
    runner.run_c_data()
  File "/arrow/dev/archery/archery/integration/runner.py", line 129, in run_c_data
    self._compare_c_data_implementations(producer, consumer)
  File "/arrow/dev/archery/archery/integration/runner.py", line 425, in _compare_c_data_implementations
    with consumer.make_c_data_importer() as importer:
  File "/arrow/dev/archery/archery/integration/tester_java.py", line 349, in make_c_data_importer
    return JavaCDataImporter(self.debug, self.args)
  File "/arrow/dev/archery/archery/integration/tester_java.py", line 89, in __init__
    import jpype
ModuleNotFoundError: No module named 'jpype'

#38248 may be related.

Component(s)

Continuous Integration, Release

@raulcd
Copy link
Member

raulcd commented Oct 26, 2023

I think we should install jpype1 on the verification script too:
https://github.com/apache/arrow/blob/main/dev/release/verify-release-candidate.sh#L906
Same as we do here:
https://github.com/apache/arrow/pull/38248/files#diff-541c9c4d96250540b1d053548895b96e15c74001c00102b0c0c3686d8b62c54dR27

@pitrou is there any reason why we don't install those as part of archery[integration]?
https://github.com/apache/arrow/blob/main/dev/archery/setup.py#L37

Or is it ok if I just add them there?

@pitrou
Copy link
Member

pitrou commented Oct 26, 2023

They're optional for Java and C#. I don't mind adding them if they are light-weight enough to install (is it the case?).

@pitrou
Copy link
Member

pitrou commented Oct 26, 2023

(why do we have release scripts with integration? should we just remove them?)

@pitrou
Copy link
Member

pitrou commented Oct 26, 2023

The jpype1 binaries are available for a limited set of platforms, so I don't think we should make it mandatory to run integration tests:
https://pypi.org/project/JPype1/#files

Conversely, pythonnet is pure Python and only depends on cffi, so I would be ok adding it to archery[integration].

@raulcd
Copy link
Member

raulcd commented Jan 4, 2024

This should probably be fixed for the release if we want to run the integration tests. Currently nightly verification is failing for:
verify-rc-source-integration-linux-almalinux-8-amd64
verify-rc-source-integration-linux-conda-latest-amd64
verify-rc-source-integration-linux-ubuntu-20.04-amd64
verify-rc-source-integration-linux-ubuntu-22.04-amd64

@raulcd raulcd added this to the 15.0.0 milestone Jan 4, 2024
raulcd added a commit to raulcd/arrow that referenced this issue Jan 8, 2024
raulcd added a commit to raulcd/arrow that referenced this issue Jan 11, 2024
@kou kou closed this as completed in c78a1ae Jan 12, 2024
raulcd added a commit that referenced this issue Jan 12, 2024
… integration tests (#39502)

Integration verification tasks are currently failing on CI.

Install jpype and build JNI c-data to run integration tests

Yes via archery

No

* Closes: #38470

Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
…to run integration tests (apache#39502)

### Rationale for this change

Integration verification tasks are currently failing on CI.

### What changes are included in this PR?

Install jpype and build JNI c-data to run integration tests

### Are these changes tested?

Yes via archery

### Are there any user-facing changes?
No

* Closes: apache#38470

Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
…to run integration tests (apache#39502)

### Rationale for this change

Integration verification tasks are currently failing on CI.

### What changes are included in this PR?

Install jpype and build JNI c-data to run integration tests

### Are these changes tested?

Yes via archery

### Are there any user-facing changes?
No

* Closes: apache#38470

Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Feb 28, 2024
…to run integration tests (apache#39502)

### Rationale for this change

Integration verification tasks are currently failing on CI.

### What changes are included in this PR?

Install jpype and build JNI c-data to run integration tests

### Are these changes tested?

Yes via archery

### Are there any user-facing changes?
No

* Closes: apache#38470

Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
…to run integration tests (apache#39502)

### Rationale for this change

Integration verification tasks are currently failing on CI.

### What changes are included in this PR?

Install jpype and build JNI c-data to run integration tests

### Are these changes tested?

Yes via archery

### Are there any user-facing changes?
No

* Closes: apache#38470

Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment