Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] Better support for decimal values which exceed the range of the BCL's System.Decimal in Decimal256 #38483

Closed
CurtHagenlocher opened this issue Oct 26, 2023 · 0 comments · Fixed by #38508
Closed

[C#] Better support for decimal values which exceed the range of the BCL's System.Decimal in Decimal256 #38483

CurtHagenlocher opened this issue Oct 26, 2023 · 0 comments · Fixed by #38508
Assignees
@CurtHagenlocher
Labels
Component: C# Type: enhancement
Milestone
15.0.0

Comments

@CurtHagenlocher
Copy link
Contributor

Describe the enhancement requested

For Decimal128 it was possible to use System.Data.SqlTypes.SqlDecimal -- see #38351 -- but we need a wider type to be able to hold the entire range of Decimal256.

Component(s)

C#
@CurtHagenlocher CurtHagenlocher self-assigned this Oct 26, 2023
@github-actions github-actions bot mentioned this issue Oct 30, 2023
Merged
CurtHagenlocher added a commit that referenced this issue Oct 30, 2023
@CurtHagenlocher
GH-38483: [C#] Add support for more decimal conversions (#38508)
2628d49 
### What changes are included in this PR?

Adds support for decimal128 <-> string and decimal256 <-> string.
Adds support for decimal256 <-> SqlDecimal.

### Are these changes tested?

Yes

### Are there any user-facing changes?

APIs have been added to support these conversions.
* Closes: #38483

Authored-by: Curt Hagenlocher <curt@hagenlocher.org>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
@CurtHagenlocher CurtHagenlocher added this to the 15.0.0 milestone Oct 30, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@CurtHagenlocher @loicalleyne
apacheGH-38483: [C#] Add support for more decimal conversions (apache…
7b2fd3b 
…#38508)

### What changes are included in this PR?

Adds support for decimal128 <-> string and decimal256 <-> string.
Adds support for decimal256 <-> SqlDecimal.

### Are these changes tested?

Yes

### Are there any user-facing changes?

APIs have been added to support these conversions.
* Closes: apache#38483

Authored-by: Curt Hagenlocher <curt@hagenlocher.org>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@CurtHagenlocher @dgreiss
apacheGH-38483: [C#] Add support for more decimal conversions (apache…
7e6fdce 
…#38508)

### What changes are included in this PR?

Adds support for decimal128 <-> string and decimal256 <-> string.
Adds support for decimal256 <-> SqlDecimal.

### Are these changes tested?

Yes

### Are there any user-facing changes?

APIs have been added to support these conversions.
* Closes: apache#38483

Authored-by: Curt Hagenlocher <curt@hagenlocher.org>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CurtHagenlocher CurtHagenlocher

Labels
Component: C# Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38483: [C#] Add support for more decimal conversions CurtHagenlocher/arrow
1 participant
@CurtHagenlocher