Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MATLAB] Add remaining tests for arrow tabular object display #38541

Closed
leihou6116 opened this issue Nov 1, 2023 · 1 comment · Fixed by #38564
Closed

[MATLAB] Add remaining tests for arrow tabular object display #38541

leihou6116 opened this issue Nov 1, 2023 · 1 comment · Fixed by #38564

Comments

@leihou6116
Copy link
Contributor

Describe the enhancement requested

The current arrow tabular object display tests only cover basic test cases. Please add more test cases to ensure its quality.

Component(s)

MATLAB

@leihou6116
Copy link
Contributor Author

take

kevingurney pushed a commit that referenced this issue Nov 2, 2023
…ay (#38564)

### Rationale for this change

The current tests for arrow tabular display only covers basic use cases. To guarantee its quality, we need to add tests to cover more use cases.

### Added Test Cases
- display of 0-by-N tabular
- display of a very wide tabular to verify that the display is not truncated.
- display of hyperlink contained in the tabular data
- display class name when the datatype of a tabular variable is not array.
- display of null
- display of Unicode.

### Are these changes tested?

Yes.

See "Added test Cases" above.

### Are there any user-facing changes?

No
* Closes: #38541

Authored-by: Lei Hou <leihou@mathworks.com>
Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
@kevingurney kevingurney added this to the 15.0.0 milestone Nov 2, 2023
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
… display (apache#38564)

### Rationale for this change

The current tests for arrow tabular display only covers basic use cases. To guarantee its quality, we need to add tests to cover more use cases.

### Added Test Cases
- display of 0-by-N tabular
- display of a very wide tabular to verify that the display is not truncated.
- display of hyperlink contained in the tabular data
- display class name when the datatype of a tabular variable is not array.
- display of null
- display of Unicode.

### Are these changes tested?

Yes.

See "Added test Cases" above.

### Are there any user-facing changes?

No
* Closes: apache#38541

Authored-by: Lei Hou <leihou@mathworks.com>
Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
… display (apache#38564)

### Rationale for this change

The current tests for arrow tabular display only covers basic use cases. To guarantee its quality, we need to add tests to cover more use cases.

### Added Test Cases
- display of 0-by-N tabular
- display of a very wide tabular to verify that the display is not truncated.
- display of hyperlink contained in the tabular data
- display class name when the datatype of a tabular variable is not array.
- display of null
- display of Unicode.

### Are these changes tested?

Yes.

See "Added test Cases" above.

### Are there any user-facing changes?

No
* Closes: apache#38541

Authored-by: Lei Hou <leihou@mathworks.com>
Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants