Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java][FlightSQL] Remove Joda dependency #38578

Closed
laurentgo opened this issue Nov 3, 2023 · 0 comments · Fixed by #38579
Closed

[Java][FlightSQL] Remove Joda dependency #38578

laurentgo opened this issue Nov 3, 2023 · 0 comments · Fixed by #38579
Assignees
@laurentgo
Labels
Component: Java Type: enhancement
Milestone
15.0.0

Comments

@laurentgo
Copy link
Contributor

Describe the enhancement requested

joda library is a popular library used for date/time manipulation but his usage has been deprecated with the introduction of java.time module in JDK8.

The library is likely unnecessary and removing it would make flightsql client/driver a bit smaller.

Component(s)

Java
laurentgo added a commit to laurentgo/arrow that referenced this issue Nov 3, 2023
@laurentgo
apacheGH-38578: [Java][FlightSQL] Remove joda usage from flight-sql l…
8bba58f 
…ibrary

Replace joda usage in flight-sql core library with `java.util` classes
laurentgo added a commit to laurentgo/arrow that referenced this issue Nov 3, 2023
@laurentgo
apacheGH-38578: [Java][FlightSQL] Remove joda usage from flight-sql l…
9c1fa3d 
…ibrary

Replace joda usage in flight-sql core library with `java.time` classes
@github-actions github-actions bot mentioned this issue Nov 3, 2023
Merged
@lidavidm lidavidm added this to the 15.0.0 milestone Nov 6, 2023
lidavidm pushed a commit that referenced this issue Nov 6, 2023
@laurentgo
GH-38578: [Java][FlightSQL] Remove joda usage from flight-sql library (…
02d8bd2 
…#38579)

### Rationale for this change

[joda](https://www.joda.org/joda-time/) is a very popular date/time manipulation library for java but the introduction of `java.time` package makes it obsolete and author actually recommends using `java.time` over `joda`

> Note that from Java SE 8 onwards, users are asked to migrate to java.time (JSR-310) - a core part of the JDK which replaces this project.

### What changes are included in this PR?

Change include the use of `java.time` classes over `joda` classes and the removal of `joda` library as a dependency

### Are these changes tested?

As there is no behavior change, it is covered by the existing tests
* Closes: #38578

Authored-by: Laurent Goujon <laurent@apache.org>
Signed-off-by: David Li <li.davidm96@gmail.com>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Nov 9, 2023
@laurentgo @JerAguilon
apacheGH-38578: [Java][FlightSQL] Remove joda usage from flight-sql l…
ab0c5cf 
…ibrary (apache#38579)

### Rationale for this change

[joda](https://www.joda.org/joda-time/) is a very popular date/time manipulation library for java but the introduction of `java.time` package makes it obsolete and author actually recommends using `java.time` over `joda`

> Note that from Java SE 8 onwards, users are asked to migrate to java.time (JSR-310) - a core part of the JDK which replaces this project.

### What changes are included in this PR?

Change include the use of `java.time` classes over `joda` classes and the removal of `joda` library as a dependency

### Are these changes tested?

As there is no behavior change, it is covered by the existing tests
* Closes: apache#38578

Authored-by: Laurent Goujon <laurent@apache.org>
Signed-off-by: David Li <li.davidm96@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@laurentgo @loicalleyne
apacheGH-38578: [Java][FlightSQL] Remove joda usage from flight-sql l…
0fd0830 
…ibrary (apache#38579)

### Rationale for this change

[joda](https://www.joda.org/joda-time/) is a very popular date/time manipulation library for java but the introduction of `java.time` package makes it obsolete and author actually recommends using `java.time` over `joda`

> Note that from Java SE 8 onwards, users are asked to migrate to java.time (JSR-310) - a core part of the JDK which replaces this project.

### What changes are included in this PR?

Change include the use of `java.time` classes over `joda` classes and the removal of `joda` library as a dependency

### Are these changes tested?

As there is no behavior change, it is covered by the existing tests
* Closes: apache#38578

Authored-by: Laurent Goujon <laurent@apache.org>
Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@laurentgo @dgreiss
apacheGH-38578: [Java][FlightSQL] Remove joda usage from flight-sql l…
56a202c 
…ibrary (apache#38579)

### Rationale for this change

[joda](https://www.joda.org/joda-time/) is a very popular date/time manipulation library for java but the introduction of `java.time` package makes it obsolete and author actually recommends using `java.time` over `joda`

> Note that from Java SE 8 onwards, users are asked to migrate to java.time (JSR-310) - a core part of the JDK which replaces this project.

### What changes are included in this PR?

Change include the use of `java.time` classes over `joda` classes and the removal of `joda` library as a dependency

### Are these changes tested?

As there is no behavior change, it is covered by the existing tests
* Closes: apache#38578

Authored-by: Laurent Goujon <laurent@apache.org>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurentgo laurentgo

Labels
Component: Java Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38578: [Java][FlightSQL] Remove joda usage from flight-sql library laurentgo/arrow
2 participants
@lidavidm @laurentgo