Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Implement GetFileInfo selector for Azure filesystem #38597

Closed
Tom-Newton opened this issue Nov 6, 2023 · 2 comments · Fixed by #39009
Closed

[C++] Implement GetFileInfo selector for Azure filesystem #38597

Tom-Newton opened this issue Nov 6, 2023 · 2 comments · Fixed by #39009
Assignees
@felipecrv
Labels
Component: C++ Type: enhancement
Milestone
15.0.0

Comments

@Tom-Newton
Copy link
Contributor

Describe the enhancement requested

Implement AzureFileSystem::GetFileInfo(const FileSelector& select).

This should follow slightly different code paths for flat vs hierarchical namespace to take advantage of the performance benefits hierarchical namespace can provide on listing operations.
#38505 implements the first part of the filesystem that depends on hierarchical namespace so that should lay the ground work.

Related Issues:

Component(s)

C++
@Tom-Newton Tom-Newton changed the title [C++] Implement GefFileInfo selector for Azure filesystem [C++] Implement GetFileInfo selector for Azure filesystem Nov 6, 2023
@Tom-Newton Tom-Newton mentioned this issue Nov 13, 2023
Closed
@felipecrv
Copy link
Contributor

@kou are you working on this? Can I claim this task?

@kou
Copy link
Member

kou commented Nov 13, 2023

@felipecrv No. Go ahead!

@kou kou mentioned this issue Nov 14, 2023
Closed
@felipecrv felipecrv self-assigned this Nov 15, 2023
@github-actions github-actions bot mentioned this issue Nov 30, 2023
Merged
felipecrv added a commit that referenced this issue Dec 8, 2023
@felipecrv
GH-38597: [C++] Implement GetFileInfo(selector) for Azure filesystem (#…
476c78f 
…39009)

### Rationale for this change

Part of Azure FS implementation.

### What changes are included in this PR?

The version of `GetFileInfo` that takes a prefix and can optionally
recurse into directories.

### Are these changes tested?

By unit tests present in this PR. Separate from this PR, I'm thinking of
way to fuzz-test the FS API.
* Closes: #38597
@kou kou added this to the 15.0.0 milestone Dec 10, 2023
mapleFU pushed a commit to mapleFU/arrow that referenced this issue Dec 13, 2023
@felipecrv @mapleFU
apacheGH-38597: [C++] Implement GetFileInfo(selector) for Azure files…
c5e4a11 
…ystem (apache#39009)

### Rationale for this change

Part of Azure FS implementation.

### What changes are included in this PR?

The version of `GetFileInfo` that takes a prefix and can optionally
recurse into directories.

### Are these changes tested?

By unit tests present in this PR. Separate from this PR, I'm thinking of
way to fuzz-test the FS API.
* Closes: apache#38597
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@felipecrv @clayburn
apacheGH-38597: [C++] Implement GetFileInfo(selector) for Azure files…
830476d 
…ystem (apache#39009)

### Rationale for this change

Part of Azure FS implementation.

### What changes are included in this PR?

The version of `GetFileInfo` that takes a prefix and can optionally
recurse into directories.

### Are these changes tested?

By unit tests present in this PR. Separate from this PR, I'm thinking of
way to fuzz-test the FS API.
* Closes: apache#38597
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@felipecrv @dgreiss
apacheGH-38597: [C++] Implement GetFileInfo(selector) for Azure files…
798ca04 
…ystem (apache#39009)

### Rationale for this change

Part of Azure FS implementation.

### What changes are included in this PR?

The version of `GetFileInfo` that takes a prefix and can optionally
recurse into directories.

### Are these changes tested?

By unit tests present in this PR. Separate from this PR, I'm thinking of
way to fuzz-test the FS API.
* Closes: apache#38597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipecrv felipecrv

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38597: [C++] Implement GetFileInfo(selector) for Azure filesystem felipecrv/arrow
3 participants
@kou @felipecrv @Tom-Newton