Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-38602: [R] Add missing prod for summarize #38601

Merged
merged 1 commit into from Nov 6, 2023
Merged

Conversation

m-muecke
Copy link
Contributor

@m-muecke m-muecke commented Nov 6, 2023

Rationale for this change

prod is currently missing for use in summarize.

What changes are included in this PR?

Added prod for summarize aggregation.

Are these changes tested?

Yes, included the same tests used for the other aggregation functions for summarize.

Are there any user-facing changes?

Yes, added prod function.

@github-actions github-actions bot added the awaiting review Awaiting review label Nov 6, 2023
Copy link

github-actions bot commented Nov 6, 2023

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@m-muecke m-muecke changed the title [R] Add missing for summarize [R] Add missing prod for summarize Nov 6, 2023
@m-muecke m-muecke changed the title [R] Add missing prod for summarize GH-38602: [R] Add missing prod for summarize Nov 6, 2023
Copy link

github-actions bot commented Nov 6, 2023

⚠️ GitHub issue #38602 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean! Thank you!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Nov 6, 2023
@paleolimbot paleolimbot merged commit 6dcba93 into apache:main Nov 6, 2023
14 of 15 checks passed
@paleolimbot paleolimbot removed the awaiting merge Awaiting merge label Nov 6, 2023
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 6dcba93.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

JerAguilon pushed a commit to JerAguilon/arrow that referenced this pull request Nov 9, 2023
### Rationale for this change

`prod` is currently missing for use in summarize.

### What changes are included in this PR?

Added `prod` for summarize aggregation.

### Are these changes tested?

Yes, included the same tests used for the other aggregation functions for summarize.

### Are there any user-facing changes?

Yes, added `prod` function.

* Closes: apache#38602

Authored-by: Maximilian Muecke <muecke.maximilian@gmail.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
### Rationale for this change

`prod` is currently missing for use in summarize.

### What changes are included in this PR?

Added `prod` for summarize aggregation.

### Are these changes tested?

Yes, included the same tests used for the other aggregation functions for summarize.

### Are there any user-facing changes?

Yes, added `prod` function.

* Closes: apache#38602

Authored-by: Maximilian Muecke <muecke.maximilian@gmail.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
### Rationale for this change

`prod` is currently missing for use in summarize.

### What changes are included in this PR?

Added `prod` for summarize aggregation.

### Are these changes tested?

Yes, included the same tests used for the other aggregation functions for summarize.

### Are there any user-facing changes?

Yes, added `prod` function.

* Closes: apache#38602

Authored-by: Maximilian Muecke <muecke.maximilian@gmail.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[R] Implement missing prod function for summarize
2 participants