Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] Implement missing prod function for summarize #38602

Closed
m-muecke opened this issue Nov 6, 2023 · 0 comments · Fixed by #38601
Closed

[R] Implement missing prod function for summarize #38602

m-muecke opened this issue Nov 6, 2023 · 0 comments · Fixed by #38601
Assignees
@m-muecke
Labels
Component: R Type: enhancement
Milestone
15.0.0

Comments

@m-muecke
Copy link
Contributor

m-muecke commented Nov 6, 2023

Describe the enhancement requested

Add missing prod function for summarize.

Component(s)

R
@github-actions github-actions bot mentioned this issue Nov 6, 2023
Merged
paleolimbot pushed a commit that referenced this issue Nov 6, 2023
@m-muecke
GH-38602: [R] Add missing prod for summarize (#38601)
6dcba93 
### Rationale for this change

`prod` is currently missing for use in summarize.

### What changes are included in this PR?

Added `prod` for summarize aggregation.

### Are these changes tested?

Yes, included the same tests used for the other aggregation functions for summarize.

### Are there any user-facing changes?

Yes, added `prod` function.

* Closes: #38602

Authored-by: Maximilian Muecke <muecke.maximilian@gmail.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
@paleolimbot paleolimbot added this to the 15.0.0 milestone Nov 6, 2023
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Nov 9, 2023
@m-muecke @JerAguilon
apacheGH-38602: [R] Add missing prod for summarize (apache#38601)
970bf3b 
### Rationale for this change

`prod` is currently missing for use in summarize.

### What changes are included in this PR?

Added `prod` for summarize aggregation.

### Are these changes tested?

Yes, included the same tests used for the other aggregation functions for summarize.

### Are there any user-facing changes?

Yes, added `prod` function.

* Closes: apache#38602

Authored-by: Maximilian Muecke <muecke.maximilian@gmail.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@m-muecke @loicalleyne
apacheGH-38602: [R] Add missing prod for summarize (apache#38601)
071b5d1 
### Rationale for this change

`prod` is currently missing for use in summarize.

### What changes are included in this PR?

Added `prod` for summarize aggregation.

### Are these changes tested?

Yes, included the same tests used for the other aggregation functions for summarize.

### Are there any user-facing changes?

Yes, added `prod` function.

* Closes: apache#38602

Authored-by: Maximilian Muecke <muecke.maximilian@gmail.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@m-muecke @dgreiss
apacheGH-38602: [R] Add missing prod for summarize (apache#38601)
189cc98 
### Rationale for this change

`prod` is currently missing for use in summarize.

### What changes are included in this PR?

Added `prod` for summarize aggregation.

### Are these changes tested?

Yes, included the same tests used for the other aggregation functions for summarize.

### Are there any user-facing changes?

Yes, added `prod` function.

* Closes: apache#38602

Authored-by: Maximilian Muecke <muecke.maximilian@gmail.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-muecke m-muecke

Labels
Component: R Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38602: [R] Add missing prod for summarize m-muecke/arrow
2 participants
@paleolimbot @m-muecke