Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java][FlightRPC] Handle null values for JDBC parameters and improve exception #38627

Closed
aiguofer opened this issue Nov 7, 2023 · 0 comments · Fixed by #38628
Closed

[Java][FlightRPC] Handle null values for JDBC parameters and improve exception #38627

aiguofer opened this issue Nov 7, 2023 · 0 comments · Fixed by #38628
Assignees
@aiguofer
Labels
Component: Java Type: enhancement
Milestone
15.0.0

Comments

@aiguofer
Copy link
Contributor

aiguofer commented Nov 7, 2023

Describe the enhancement requested

Follow up based on #38585. We need to support binding null values and use a UnsupportedOperationException instead of RuntimeException for unsupported parameter binding operations.

Component(s)

Java
@github-actions github-actions bot mentioned this issue Nov 7, 2023
Merged
lidavidm pushed a commit that referenced this issue Nov 8, 2023
@aiguofer
GH-38627: [Java][FlightRPC] Handle null parameter values (#38628)
db19a35 
### Rationale for this change

We want to make sure we correctly handle binding `null` values to JDBC parameters.
We also want better exceptions when handling parameter binding.

### What changes are included in this PR?

- Handle adding null values to parameters if it's a nullable vector, else throw `UnsupportedOperationException`
- For unsupported parameter types or casts, throw `UnsupportedOperationException` instead of `RuntimeException`
* Closes: #38627

Authored-by: Diego Fernandez <aiguo.fernandez@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
@lidavidm lidavidm added this to the 15.0.0 milestone Nov 8, 2023
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue Nov 9, 2023
@aiguofer @JerAguilon
apacheGH-38627: [Java][FlightRPC] Handle null parameter values (apach…
aaa829b 
…e#38628)

### Rationale for this change

We want to make sure we correctly handle binding `null` values to JDBC parameters.
We also want better exceptions when handling parameter binding.

### What changes are included in this PR?

- Handle adding null values to parameters if it's a nullable vector, else throw `UnsupportedOperationException`
- For unsupported parameter types or casts, throw `UnsupportedOperationException` instead of `RuntimeException`
* Closes: apache#38627

Authored-by: Diego Fernandez <aiguo.fernandez@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this issue Nov 13, 2023
@aiguofer @loicalleyne
apacheGH-38627: [Java][FlightRPC] Handle null parameter values (apach…
0a714b9 
…e#38628)

### Rationale for this change

We want to make sure we correctly handle binding `null` values to JDBC parameters.
We also want better exceptions when handling parameter binding.

### What changes are included in this PR?

- Handle adding null values to parameters if it's a nullable vector, else throw `UnsupportedOperationException`
- For unsupported parameter types or casts, throw `UnsupportedOperationException` instead of `RuntimeException`
* Closes: apache#38627

Authored-by: Diego Fernandez <aiguo.fernandez@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@aiguofer @dgreiss
apacheGH-38627: [Java][FlightRPC] Handle null parameter values (apach…
6e71812 
…e#38628)

### Rationale for this change

We want to make sure we correctly handle binding `null` values to JDBC parameters.
We also want better exceptions when handling parameter binding.

### What changes are included in this PR?

- Handle adding null values to parameters if it's a nullable vector, else throw `UnsupportedOperationException`
- For unsupported parameter types or casts, throw `UnsupportedOperationException` instead of `RuntimeException`
* Closes: apache#38627

Authored-by: Diego Fernandez <aiguo.fernandez@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aiguofer aiguofer

Labels
Component: Java Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38627: [Java][FlightRPC] Handle null parameter values aiguofer/arrow
2 participants
@lidavidm @aiguofer