Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] More default vector comparators #38662

Closed
jduo opened this issue Nov 9, 2023 · 1 comment · Fixed by #38669
Closed

[Java] More default vector comparators #38662

jduo opened this issue Nov 9, 2023 · 1 comment · Fixed by #38669
Assignees
@jduo
Labels
Component: Java Type: enhancement
Milestone
15.0.0

Comments

@jduo
Copy link
Member

jduo commented Nov 9, 2023

Describe the enhancement requested

There are still a few gaps in DefaultVectorComparators:

  • FixedSizeBinaryVector
  • LargeListVector
  • FixedSizeListVector

NullVector is also missing one, though sorting is irrelevant. Perhaps a trivial comparator that just returns equality always.
StructVector does not really make sense to make comparable.

Component(s)

Java
@jduo
Copy link
Member Author

jduo commented Nov 9, 2023

take

jduo added a commit to Bit-Quill/arrow that referenced this issue Nov 10, 2023
@jduo
apacheGH-38662: [Java] Add comparators
9410091 
Add comparators for:
- FixedSizeBinaryVector
- LargeListVector
- FixedSizeListVector
- NullVector
@github-actions github-actions bot mentioned this issue Nov 10, 2023
Merged
jduo added a commit to Bit-Quill/arrow that referenced this issue Nov 14, 2023
@jduo
apacheGH-38662: [Java] Add comparators
6e6989b 
Add comparators for:
- FixedSizeBinaryVector
- LargeListVector
- FixedSizeListVector
- NullVector
@lidavidm lidavidm added this to the 15.0.0 milestone Nov 14, 2023
lidavidm pushed a commit that referenced this issue Nov 14, 2023
@jduo
GH-38662: [Java] Add comparators (#38669)
a408020 
### Rationale for this change
Add missing Default VectorValueComparators for some more types.

### What changes are included in this PR?
Add comparators for:
- FixedSizeBinaryVector
- LargeListVector
- FixedSizeListVector
- NullVector

### Are these changes tested?
Yes, unit tests added.

### Are there any user-facing changes?
No
* Closes: #38662

Authored-by: James Duong <james.duong@improving.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@jduo @dgreiss
apacheGH-38662: [Java] Add comparators (apache#38669)
04bf403 
### Rationale for this change
Add missing Default VectorValueComparators for some more types.

### What changes are included in this PR?
Add comparators for:
- FixedSizeBinaryVector
- LargeListVector
- FixedSizeListVector
- NullVector

### Are these changes tested?
Yes, unit tests added.

### Are there any user-facing changes?
No
* Closes: apache#38662

Authored-by: James Duong <james.duong@improving.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jduo jduo

Labels
Component: Java Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38662: [Java] Add comparators Bit-Quill/arrow
2 participants
@lidavidm @jduo