Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] Implement ICollection<T?> on scalar arrays #38692

Closed
voidstar69 opened this issue Nov 13, 2023 · 1 comment · Fixed by #41539
Closed

[C#] Implement ICollection<T?> on scalar arrays #38692

voidstar69 opened this issue Nov 13, 2023 · 1 comment · Fixed by #41539
Assignees
@voidstar69
Labels
Component: C# Type: enhancement
Milestone
17.0.0

Comments

@voidstar69
Copy link
Contributor

voidstar69 commented Nov 13, 2023 •
edited

Describe the enhancement requested

Issue split off from issue #38348.

Describe the enhancement requested

If Arrow arrays of scalar type T were to implement ICollection<T?>, it would optimize their use with LINQ (pre-.NET 9), allowing for e.g. fast conversion to lists via the extension method ToList().

This change would to some extent supersede and/or resolve #23892, #35199 and #37359.

Component(s)

C#
@voidstar69 voidstar69 mentioned this issue Nov 13, 2023
Merged
voidstar69 pushed a commit to voidstar69/arrow that referenced this issue May 5, 2024
apacheGH-38692: [C#] Make PrimitiveArray<T> support ICollection<T?>
bd849dd
@github-actions github-actions bot mentioned this issue May 5, 2024
Merged
CurtHagenlocher pushed a commit that referenced this issue May 13, 2024
@voidstar69
GH-38692: [C#] Implement ICollection<T?> on scalar arrays (#41539)
a715ea0 
### What changes are included in this PR?

This PR makes the following array types support ICollection<T?> :
- PrimitiveArray
- BooleanArray
- Date32Array
- Date64Array
- Time32Array
- Time64Array
- BinaryArray
- TimestampArray
- StringArray

### Are these changes tested?

Yes

### Are there any user-facing changes?

No

Closes #38692
* GitHub Issue: #38692

Authored-by: voidstar69 <voidstar69@gmail.com>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
@CurtHagenlocher CurtHagenlocher added this to the 17.0.0 milestone May 13, 2024
@CurtHagenlocher
Copy link
Contributor

Issue resolved by pull request 41539
#41539

CurtHagenlocher pushed a commit to CurtHagenlocher/arrow that referenced this issue May 13, 2024
@voidstar69 @CurtHagenlocher
apacheGH-38692: [C#] Implement ICollection<T?> on scalar arrays (apac…
2f135fa 
…he#41539)

### What changes are included in this PR?

This PR makes the following array types support ICollection<T?> :
- PrimitiveArray
- BooleanArray
- Date32Array
- Date64Array
- Time32Array
- Time64Array
- BinaryArray
- TimestampArray
- StringArray

### Are these changes tested?

Yes

### Are there any user-facing changes?

No

Closes apache#38692
* GitHub Issue: apache#38692

Authored-by: voidstar69 <voidstar69@gmail.com>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue May 25, 2024
@voidstar69 @vibhatha
apacheGH-38692: [C#] Implement ICollection<T?> on scalar arrays (apac…
de45f75 
…he#41539)

### What changes are included in this PR?

This PR makes the following array types support ICollection<T?> :
- PrimitiveArray
- BooleanArray
- Date32Array
- Date64Array
- Time32Array
- Time64Array
- BinaryArray
- TimestampArray
- StringArray

### Are these changes tested?

Yes

### Are there any user-facing changes?

No

Closes apache#38692
* GitHub Issue: apache#38692

Authored-by: voidstar69 <voidstar69@gmail.com>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
JerAguilon pushed a commit to JerAguilon/arrow that referenced this issue May 29, 2024
@voidstar69 @JerAguilon
apacheGH-38692: [C#] Implement ICollection<T?> on scalar arrays (apac…
ca0c561 
…he#41539)

### What changes are included in this PR?

This PR makes the following array types support ICollection<T?> :
- PrimitiveArray
- BooleanArray
- Date32Array
- Date64Array
- Time32Array
- Time64Array
- BinaryArray
- TimestampArray
- StringArray

### Are these changes tested?

Yes

### Are there any user-facing changes?

No

Closes apache#38692
* GitHub Issue: apache#38692

Authored-by: voidstar69 <voidstar69@gmail.com>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@voidstar69 voidstar69

Labels
Component: C# Type: enhancement
Projects
None yet
Milestone
17.0.0
Development

Successfully merging a pull request may close this issue.

GH-38692: [C#] Implement ICollection<T?> on scalar arrays voidstar69/arrow
2 participants
@CurtHagenlocher @voidstar69