Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][FS][Azure] Implement DeleteDirContents() #38701

Closed
kou opened this issue Nov 14, 2023 · 0 comments · Fixed by #38888
Closed

[C++][FS][Azure] Implement DeleteDirContents() #38701

kou opened this issue Nov 14, 2023 · 0 comments · Fixed by #38888
Assignees
@kou
Labels
Component: C++ Type: enhancement
Milestone
15.0.0

Comments

@kou
Copy link
Member

kou commented Nov 14, 2023

Describe the enhancement requested

It's not implemented yet.

This is a child of GH-18014.

Component(s)

C++
@kou kou mentioned this issue Nov 14, 2023
Closed
kou added a commit to kou/arrow that referenced this issue Nov 27, 2023
@kou
apacheGH-38701: [C++][FS][Azure] Implement DeleteDirContents()
43ccf67
@github-actions github-actions bot mentioned this issue Nov 27, 2023
Merged
kou added a commit to kou/arrow that referenced this issue Dec 1, 2023
@kou
apacheGH-38701: [C++][FS][Azure] Implement DeleteDirContents()
cc40c20
@kou kou closed this as completed in #38888 Dec 1, 2023
kou added a commit that referenced this issue Dec 1, 2023
@kou
GH-38701: [C++][FS][Azure] Implement DeleteDirContents() (#38888)
db69b67 
### Rationale for this change

`DeleteDirContents()` deletes the given directory contents recursively like other filesystem implementations.

Azure file system treats the following cases as root directory:
* Empty container
* Empty path

### What changes are included in this PR?

List and delete approach is used with/without hierarchical namespace support. Because Azure doesn't provide "DeleteDirContents" API with hierarchical namespace support. We may want to use delete the given directory and create an empty approach instead of list and delete approach for performance but it may not be acceptable with some use cases. 

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #38701

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 15.0.0 milestone Dec 1, 2023
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@kou @dgreiss
apacheGH-38701: [C++][FS][Azure] Implement DeleteDirContents() (apa…
282d905 
…che#38888)

### Rationale for this change

`DeleteDirContents()` deletes the given directory contents recursively like other filesystem implementations.

Azure file system treats the following cases as root directory:
* Empty container
* Empty path

### What changes are included in this PR?

List and delete approach is used with/without hierarchical namespace support. Because Azure doesn't provide "DeleteDirContents" API with hierarchical namespace support. We may want to use delete the given directory and create an empty approach instead of list and delete approach for performance but it may not be acceptable with some use cases. 

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#38701

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38701: [C++][FS][Azure] Implement DeleteDirContents() kou/arrow
1 participant
@kou