Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][FS][Azure] Implement DeleteRootDirContents() #38702

Closed
kou opened this issue Nov 14, 2023 · 0 comments · Fixed by #39151
Closed

[C++][FS][Azure] Implement DeleteRootDirContents() #38702

kou opened this issue Nov 14, 2023 · 0 comments · Fixed by #39151
Assignees
@felipecrv
Labels
Component: C++ Type: enhancement
Milestone
15.0.0

Comments

@kou
Copy link
Member

kou commented Nov 14, 2023

Describe the enhancement requested

It's not implemented yet.

This is a child of GH-18014.

Component(s)

C++
@kou kou mentioned this issue Nov 14, 2023
Closed
@felipecrv felipecrv self-assigned this Dec 8, 2023
@github-actions github-actions bot mentioned this issue Dec 8, 2023
Merged
felipecrv added a commit that referenced this issue Dec 10, 2023
@felipecrv
GH-38702 [C++]: Implement AzureFileSystem::DeleteRootDirContents (#39151
47f4d18 
)

### Rationale for this change

This copies the behavior implemented by S3FileSystem.

### What changes are included in this PR?

An implementation of `DeleteRootDirContent` that prevents deletion of all blob containers.

### Are these changes tested?

N/A.
* Closes: #38702

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
@felipecrv felipecrv added this to the 15.0.0 milestone Dec 10, 2023
mapleFU pushed a commit to mapleFU/arrow that referenced this issue Dec 13, 2023
@felipecrv @mapleFU
apacheGH-38702 [C++]: Implement AzureFileSystem::DeleteRootDirContents (
40b1c68 
apache#39151)

### Rationale for this change

This copies the behavior implemented by S3FileSystem.

### What changes are included in this PR?

An implementation of `DeleteRootDirContent` that prevents deletion of all blob containers.

### Are these changes tested?

N/A.
* Closes: apache#38702

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
clayburn pushed a commit to clayburn/arrow that referenced this issue Jan 23, 2024
@felipecrv @clayburn
apacheGH-38702 [C++]: Implement AzureFileSystem::DeleteRootDirContents (
5dfe404 
apache#39151)

### Rationale for this change

This copies the behavior implemented by S3FileSystem.

### What changes are included in this PR?

An implementation of `DeleteRootDirContent` that prevents deletion of all blob containers.

### Are these changes tested?

N/A.
* Closes: apache#38702

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@felipecrv @dgreiss
apacheGH-38702 [C++]: Implement AzureFileSystem::DeleteRootDirContents (
e38132f 
apache#39151)

### Rationale for this change

This copies the behavior implemented by S3FileSystem.

### What changes are included in this PR?

An implementation of `DeleteRootDirContent` that prevents deletion of all blob containers.

### Are these changes tested?

N/A.
* Closes: apache#38702

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipecrv felipecrv

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38702 [C++]: Implement AzureFileSystem::DeleteRootDirContents felipecrv/arrow
2 participants
@kou @felipecrv