Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Check for valid variadic buffer counts #38738

Closed
bkietz opened this issue Nov 15, 2023 · 0 comments · Fixed by #38740
Closed

[C++] Check for valid variadic buffer counts #38738

bkietz opened this issue Nov 15, 2023 · 0 comments · Fixed by #38740
Assignees
@bkietz
Labels
Component: C++ Type: bug
Milestone
15.0.0

Comments

@bkietz
Copy link
Member

bkietz commented Nov 15, 2023

Describe the bug, including details regarding any error messages, version, and platform.

Variadic buffer count is stored as int64 and is used to presize vectors when reading IPC. These aren't validated for representability in a positive int32, which led to some fuzzer failures.

Component(s)

C++
@bkietz bkietz self-assigned this Nov 15, 2023
bkietz added a commit to bkietz/arrow that referenced this issue Nov 15, 2023
@bkietz
apacheGH-38738: [C++] Check variadic buffer counts in bounds
4104f15
@github-actions github-actions bot mentioned this issue Nov 15, 2023
Merged
bkietz added a commit that referenced this issue Nov 27, 2023
@bkietz @pitrou
GH-38738: [C++] Check variadic buffer counts in bounds (#38740)
84c15da 
### Rationale for this change

Invalid variadic buffer counts can cause allocating storage for variadic buffers to fail.

### What changes are included in this PR?

Check variadic buffer counts are valid before they are used as an allocator argument.

### Are these changes tested?

They pass with the fuzzer testcase.

### Are there any user-facing changes?

No

* Closes: #38738

Lead-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
@bkietz bkietz added this to the 15.0.0 milestone Nov 27, 2023
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@bkietz @pitrou @dgreiss
apacheGH-38738: [C++] Check variadic buffer counts in bounds (apache#…
dc5fab3 
…38740)

### Rationale for this change

Invalid variadic buffer counts can cause allocating storage for variadic buffers to fail.

### What changes are included in this PR?

Check variadic buffer counts are valid before they are used as an allocator argument.

### Are these changes tested?

They pass with the fuzzer testcase.

### Are there any user-facing changes?

No

* Closes: apache#38738

Lead-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Signed-off-by: Benjamin Kietzman <bengilgit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkietz bkietz

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38738: [C++] Check variadic buffer counts in bounds bkietz/arrow
1 participant
@bkietz