Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Reword warning about required --add-opens=java.base/java.nio=ALL-UNNAMED #38764

Closed
jsoref opened this issue Nov 17, 2023 · 0 comments · Fixed by #38765
Closed

[Java] Reword warning about required --add-opens=java.base/java.nio=ALL-UNNAMED #38764

jsoref opened this issue Nov 17, 2023 · 0 comments · Fixed by #38765
Assignees
@jsoref
Labels
Component: Java Type: bug
Milestone
15.0.0

Comments

@jsoref
Copy link
Contributor

jsoref commented Nov 17, 2023

Describe the bug, including details regarding any error messages, version, and platform.

We upgraded a java app's JRE to 21 and the java app apparently uses arrow, it reported this:

java.lang.RuntimeException: Failed to initialize MemoryUtil. Was Java started with --add-opens=java.base/java.nio=ALL-UNNAMED? (See https://arrow.apache.org/docs/java/install.html)

It should say without not with.

Component(s)

Java
jsoref added a commit to jsoref/apache-arrow that referenced this issue Nov 17, 2023
@jsoref
apacheGH-38764: [JAVA] Clarify warning about `--add-opens=java.base/j…
24f7eb5 
…ava.nio=ALL-UNNAMED`

When someone encounters this message, it's precisely because they did *not* include `--add-opens=java.base/java.nio=ALL-UNNAMED`, but in order for arrow to work, they will need to add it.
@jsoref jsoref mentioned this issue Nov 17, 2023
Merged
jsoref added a commit to jsoref/apache-arrow that referenced this issue Nov 17, 2023
@jsoref
apacheGH-38764: [JAVA] Clarify warning about `--add-opens=java.base/j…
03bf900 
…ava.nio=ALL-UNNAMED`

When someone encounters this message, it's precisely because they did *not* include `--add-opens=java.base/java.nio=ALL-UNNAMED`, but in order for arrow to work, they will need to add it.
jsoref added a commit to jsoref/apache-arrow that referenced this issue Nov 19, 2023
@jsoref
apacheGH-38764: [JAVA] Clarify warning about `--add-opens=java.base/j…
291c56a 
…ava.nio=ALL-UNNAMED`

When someone encounters this message, it's precisely because they did *not* include `--add-opens=java.base/java.nio=ALL-UNNAMED`, but in order for arrow to work, they will need to add it.
@lidavidm lidavidm changed the title Reword warning about required --add-opens=java.base/java.nio=ALL-UNNAMED [Java] Reword warning about required --add-opens=java.base/java.nio=ALL-UNNAMED Nov 20, 2023
@lidavidm lidavidm added this to the 15.0.0 milestone Nov 20, 2023
lidavidm pushed a commit that referenced this issue Nov 20, 2023
@jsoref
GH-38764: [Java] Clarify warning about `--add-opens=java.base/java.ni…
c21d197 
…o=ALL-UNNAMED` (#38765)

### Rationale for this change

When someone encounters this message, it's precisely because they did *not* include `--add-opens=java.base/java.nio=ALL-UNNAMED`, but in order for arrow to work, they will need to add it.

#38764

### What changes are included in this PR?

Changes `with` to `without`

### Are these changes tested?

### Are there any user-facing changes?

The error message when arrow is run on a modern JVM will change from `with` to `without`:
> java.lang.RuntimeException: Failed to initialize MemoryUtil. Was Java started without `--add-opens=java.base/java.nio=ALL-UNNAMED`? (See https://arrow.apache.org/docs/java/install.html)

* Closes: #38764

Authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@jsoref @dgreiss
apacheGH-38764: [Java] Clarify warning about `--add-opens=java.base/j…
dcc7f0d 
…ava.nio=ALL-UNNAMED` (apache#38765)

### Rationale for this change

When someone encounters this message, it's precisely because they did *not* include `--add-opens=java.base/java.nio=ALL-UNNAMED`, but in order for arrow to work, they will need to add it.

apache#38764

### What changes are included in this PR?

Changes `with` to `without`

### Are these changes tested?

### Are there any user-facing changes?

The error message when arrow is run on a modern JVM will change from `with` to `without`:
> java.lang.RuntimeException: Failed to initialize MemoryUtil. Was Java started without `--add-opens=java.base/java.nio=ALL-UNNAMED`? (See https://arrow.apache.org/docs/java/install.html)

* Closes: apache#38764

Authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsoref jsoref

Labels
Component: Java Type: bug
Projects
None yet
Milestone
15.0.0
2 participants
@lidavidm @jsoref