Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++][FS][Azure] CreateDir("/container/", true) fails with hierarchical namespace support #38782

Closed
kou opened this issue Nov 19, 2023 · 0 comments · Fixed by #38783
Closed

[C++][FS][Azure] CreateDir("/container/", true) fails with hierarchical namespace support #38782

kou opened this issue Nov 19, 2023 · 0 comments · Fixed by #38783
Assignees
@kou
Labels
Component: C++ Type: bug
Milestone
15.0.0

Comments

@kou
Copy link
Member

kou commented Nov 19, 2023

Describe the bug, including details regarding any error messages, version, and platform.

cpp/src/arrow/filesystem/azurefs_test.cc:455: Failure
Failed
'fs_->CreateDir(container_name, true)' failed with IOError: Failed to create a directory:  (https://XXX.blob.core.windows.net/uh7qkquh4kkpm1fgjqfuns60209aha72/) Azure Error: 400 The request URI is invalid.
The request URI is invalid.
RequestId:ab3b641f-201f-005e-1fb0-1a5567000000
Time:2023-11-19T06:20:17.0150788Z
Request ID: ab3b641f-201f-005e-1fb0-1a5567000000
[  FAILED  ] AzureHierarchicalNamespaceFileSystemTest.CreateDirRecursiveSuccessContainerOnly (151 ms)

Component(s)

C++
@kou kou added the Type: bug label Nov 19, 2023
@kou kou mentioned this issue Nov 19, 2023
Merged
@kou kou changed the title [C++][FS][Azure] CreateDir("/container/") fails with hierarchical namespace support [C++][FS][Azure] CreateDir("/container/", true) fails with hierarchical namespace support Nov 19, 2023
kou added a commit to kou/arrow that referenced this issue Nov 19, 2023
@kou
apacheGH-38782: [C++][FS][Azure] Do nothing for CreateDir("/container…
7bf8827 
…", true)

It's failed with hierarchical namespace support. And we don't need to
do nothing for the case.
@github-actions github-actions bot mentioned this issue Nov 19, 2023
Merged
kou added a commit that referenced this issue Nov 19, 2023
@kou
GH-38782: [C++][FS][Azure] Do nothing for CreateDir("/container", tru…
7df1cdd 
…e) (#38783)

### Rationale for this change

It's failed with hierarchical namespace support. And we don't need to do nothing for the case because container must exist in the case.

### What changes are included in this PR?

Add a missing `location.path.empty()` check.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #38782

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 15.0.0 milestone Nov 19, 2023
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@kou @dgreiss
apacheGH-38782: [C++][FS][Azure] Do nothing for CreateDir("/container…
8f8f4df 
…", true) (apache#38783)

### Rationale for this change

It's failed with hierarchical namespace support. And we don't need to do nothing for the case because container must exist in the case.

### What changes are included in this PR?

Add a missing `location.path.empty()` check.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#38782

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38782: [C++][FS][Azure] Do nothing for CreateDir("/container", true) kou/arrow
1 participant
@kou