Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] IArrowRecord implementation on StructArray is broken #38816

Closed
CurtHagenlocher opened this issue Nov 21, 2023 · 0 comments · Fixed by #38827
Closed

[C#] IArrowRecord implementation on StructArray is broken #38816

CurtHagenlocher opened this issue Nov 21, 2023 · 0 comments · Fixed by #38827
Assignees
@CurtHagenlocher
Labels
Component: C# Type: bug
Milestone
15.0.0

Comments

@CurtHagenlocher
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

The IArrowRecord implementation on StructArray should go through the Fields property instead of the _fields field because _fields is sometimes lazily initialized.

Component(s)

C#
@CurtHagenlocher CurtHagenlocher self-assigned this Nov 21, 2023
@CurtHagenlocher CurtHagenlocher changed the title [C#] [C#] IArrowRecord implementation on StructArray is broken Nov 21, 2023
@github-actions github-actions bot mentioned this issue Nov 21, 2023
Merged
CurtHagenlocher added a commit that referenced this issue Nov 21, 2023
@CurtHagenlocher
GH-38816: [C#] Fix IArrowRecord implementation on StructArray (#38827)
c5a1eb0 
### What changes are included in this PR?

Minor bug fix, test for the bug, and a few additional tests which were missed by the previous PR.

### Are these changes tested?

Yes

### Are there any user-facing changes?

No

* Closes: #38816

Authored-by: Curt Hagenlocher <curt@hagenlocher.org>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
@CurtHagenlocher CurtHagenlocher added this to the 15.0.0 milestone Nov 21, 2023
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@CurtHagenlocher @dgreiss
apacheGH-38816: [C#] Fix IArrowRecord implementation on StructArray (a…
aa7670e 
…pache#38827)

### What changes are included in this PR?

Minor bug fix, test for the bug, and a few additional tests which were missed by the previous PR.

### Are these changes tested?

Yes

### Are there any user-facing changes?

No

* Closes: apache#38816

Authored-by: Curt Hagenlocher <curt@hagenlocher.org>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CurtHagenlocher CurtHagenlocher

Labels
Component: C# Type: bug
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38816: [C#] Fix IArrowRecord implementation on StructArray CurtHagenlocher/arrow
1 participant
@CurtHagenlocher