Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][Parquet] Skip TestArrowReaderAdHoc.ReadFloat16Files when snappy is not built #38823

Closed
wgtmac opened this issue Nov 21, 2023 · 0 comments · Fixed by #38825
Closed

[C++][Parquet] Skip TestArrowReaderAdHoc.ReadFloat16Files when snappy is not built #38823

wgtmac opened this issue Nov 21, 2023 · 0 comments · Fixed by #38825

Comments

@wgtmac
Copy link
Member

wgtmac commented Nov 21, 2023

Describe the bug, including details regarding any error messages, version, and platform.

https://github.com/ursacomputing/crossbow/actions/runs/6943255937/job/18887922572 failed with following error:

[ RUN      ] TestArrowReaderAdHoc.ReadFloat16Files
/arrow/cpp/src/parquet/arrow/arrow_reader_writer_test.cc:4129: Failure
Failed
'reader->ReadTable(&table)' failed with NotImplemented: Support for codec 'snappy' not built
Google Test trace:
/arrow/cpp/src/parquet/arrow/arrow_reader_writer_test.cc:4123: path = /arrow/cpp/submodules/parquet-testing/data/float16_nonzeros_and_nans.parquet
[  FAILED  ] TestArrowReaderAdHoc.ReadFloat16Files (1 ms)
[----------] 6 tests from TestArrowReaderAdHoc (11 ms total)

Component(s)

C++, Parquet

wgtmac added a commit to wgtmac/arrow that referenced this issue Nov 21, 2023
wgtmac added a commit to wgtmac/arrow that referenced this issue Nov 22, 2023
wgtmac added a commit that referenced this issue Nov 23, 2023
…ressed files (#38825)

### Rationale for this change

[ RUN      ] TestArrowReaderAdHoc.ReadFloat16Files
/arrow/cpp/src/parquet/arrow/arrow_reader_writer_test.cc:4129: Failure
Failed
'reader->ReadTable(&table)' failed with NotImplemented: Support for codec 'snappy' not built
Google Test trace:
/arrow/cpp/src/parquet/arrow/arrow_reader_writer_test.cc:4123: path = /arrow/cpp/submodules/parquet-testing/data/float16_nonzeros_and_nans.parquet
[  FAILED  ] TestArrowReaderAdHoc.ReadFloat16Files (1 ms)
[----------] 6 tests from TestArrowReaderAdHoc (11 ms total)

### What changes are included in this PR?

Use uncompressed files from parquet-testing.

### Are these changes tested?

Make sure the test does not fail.

### Are there any user-facing changes?

No
* Closes: #38823

Authored-by: Gang Wu <ustcwg@gmail.com>
Signed-off-by: Gang Wu <ustcwg@gmail.com>
@wgtmac wgtmac added this to the 15.0.0 milestone Nov 23, 2023
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
…uncompressed files (apache#38825)

### Rationale for this change

[ RUN      ] TestArrowReaderAdHoc.ReadFloat16Files
/arrow/cpp/src/parquet/arrow/arrow_reader_writer_test.cc:4129: Failure
Failed
'reader->ReadTable(&table)' failed with NotImplemented: Support for codec 'snappy' not built
Google Test trace:
/arrow/cpp/src/parquet/arrow/arrow_reader_writer_test.cc:4123: path = /arrow/cpp/submodules/parquet-testing/data/float16_nonzeros_and_nans.parquet
[  FAILED  ] TestArrowReaderAdHoc.ReadFloat16Files (1 ms)
[----------] 6 tests from TestArrowReaderAdHoc (11 ms total)

### What changes are included in this PR?

Use uncompressed files from parquet-testing.

### Are these changes tested?

Make sure the test does not fail.

### Are there any user-facing changes?

No
* Closes: apache#38823

Authored-by: Gang Wu <ustcwg@gmail.com>
Signed-off-by: Gang Wu <ustcwg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant