New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Go] Enable GC checks #38824
Comments
@zeroshade What do you think? |
Well, trying this I'm getting lots of integration failures locally such as:
|
Ok, it seems to be because of golang/go#42131 (comment) Hats off to Go for excellent documentation as usual. |
In the past, when we've encountered this it has been that we weren't zero'ing out one of the C structs before it being passed to a function and the pointer checker was seeing garbage that happened to look similarly to a Go pointer which triggered the error. I'm guessing there's another spot where we're failing to zero out the struct and probably need to add another trampoline like we did before. All that being said, I agree we should probably enable the checks for CGO CI builds and integrations |
### What changes are included in this PR? Our codebase has many uses of `unsafe.Pointer`. It may be a good idea to add debug checks for these uses in CI builds, especially where data crosses C boundaries. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: #38824 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
### What changes are included in this PR? Our codebase has many uses of `unsafe.Pointer`. It may be a good idea to add debug checks for these uses in CI builds, especially where data crosses C boundaries. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38824 Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Describe the enhancement requested
Judging by this sporadic failure, it seems we should enable GC checks on unsafe pointers in CGo builds:
https://github.com/apache/arrow/actions/runs/6943203792/job/18887771947?pr=38799#step:8:19738
Component(s)
Go, Integration
The text was updated successfully, but these errors were encountered: