Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] S3 filesystem have bugs on virtual hosted config #38844

Closed
liangjiawei1110 opened this issue Nov 22, 2023 · 0 comments · Fixed by #38858
Closed

[C++] S3 filesystem have bugs on virtual hosted config #38844

liangjiawei1110 opened this issue Nov 22, 2023 · 0 comments · Fixed by #38858
Assignees
@liangjiawei1110
Labels
Component: C++ Type: bug
Milestone
15.0.0

Comments

@liangjiawei1110
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

in the file /arrow/cpp/src/arrow/filesystem/s3fs.cc , at the line:917 , the bool var "use_virtual_addressing" should be set true if options_.endpoint_override is not empty , or it will throw error when connect to Oss . ref to #38135
image

Component(s)

C++
@liangjiawei1110 liangjiawei1110 changed the title Arrow S3 filesystem have bugs on virtual hosted config [C++]Arrow S3 filesystem have bugs on virtual hosted config Nov 22, 2023
@liangjiawei1110 liangjiawei1110 mentioned this issue Nov 23, 2023
Merged
pitrou added a commit that referenced this issue Dec 5, 2023
@liangjiawei1110 @pitrou
GH-38844: [C++] S3FileSystem export s3 sdk config "use_virtual_addres…
501b291 
…sing" to arrow::fs::S3Options (#38858)

### Rationale for this change
See #38844 . we should export s3 sdk config "use_virtual_addressing" to arrow::fs::S3Options so that user can decide whether to use virtual hosted by themselves. 

### Are these changes tested?
I tested it with my own OSS(aliyun object store service) bucket.As the it is a S3 compatiable service, I think 
 these changes are covered by existing tests)

### Are there any user-facing changes?

Closes: #38844  

* Closes: #38844

Lead-authored-by: ljw <wearegroot112@gmail.com>
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Co-authored-by: jiawei liang <72728602+liangjiawei1110@users.noreply.github.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 15.0.0 milestone Dec 5, 2023
@pitrou pitrou mentioned this issue Dec 5, 2023
Closed
@kou kou changed the title [C++]Arrow S3 filesystem have bugs on virtual hosted config [C++] S3 filesystem have bugs on virtual hosted config Dec 5, 2023
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@liangjiawei1110 @pitrou @dgreiss
apacheGH-38844: [C++] S3FileSystem export s3 sdk config "use_virtual_…
453aee4 
…addressing" to arrow::fs::S3Options (apache#38858)

### Rationale for this change
See apache#38844 . we should export s3 sdk config "use_virtual_addressing" to arrow::fs::S3Options so that user can decide whether to use virtual hosted by themselves. 

### Are these changes tested?
I tested it with my own OSS(aliyun object store service) bucket.As the it is a S3 compatiable service, I think 
 these changes are covered by existing tests)

### Are there any user-facing changes?

Closes: apache#38844  

* Closes: apache#38844

Lead-authored-by: ljw <wearegroot112@gmail.com>
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Co-authored-by: jiawei liang <72728602+liangjiawei1110@users.noreply.github.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liangjiawei1110 liangjiawei1110

Labels
Component: C++ Type: bug
Projects
None yet
Milestone
15.0.0
2 participants
@pitrou @liangjiawei1110