[C++] Replace #ifdef ARROW_WITH_GZIP in dataset test to ARROW_WITH_ZLIB #38852
Comments
mapleFU
added a commit
to mapleFU/arrow
that referenced
this issue
Nov 22, 2023
kou
changed the title
kou
pushed a commit
that referenced
this issue
Nov 23, 2023
…RROW_WITH_ZLIB (#38853) ### Rationale for this change We don't define `ARROW_WITH_GZIP` macro when we can use gzip. We use `ARROW_WITH_ZLIB` instead. So `ARROW_WITH_ZLIB` is always not defined. ### What changes are included in this PR? change `ARROW_WITH_GZIP` to `ARROW_WITH_ZLIB` ### Are these changes tested? previously not tested, but now there're ### Are there any user-facing changes? no * Closes: #38852 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
…t to ARROW_WITH_ZLIB (apache#38853) ### Rationale for this change We don't define `ARROW_WITH_GZIP` macro when we can use gzip. We use `ARROW_WITH_ZLIB` instead. So `ARROW_WITH_ZLIB` is always not defined. ### What changes are included in this PR? change `ARROW_WITH_GZIP` to `ARROW_WITH_ZLIB` ### Are these changes tested? previously not tested, but now there're ### Are there any user-facing changes? no * Closes: apache#38852 Authored-by: mwish <maplewish117@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
Some tests uses
ARROW_WITH_GZIPfor GZIP codec. However, arrow exactly useARROW_WITH_ZLIB.Component(s)
C++
The text was updated successfully, but these errors were encountered: