-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Wrong about the struct hiding valid children values in the example #38883
Comments
Hmm. What is the expected validity bitmaps you think? |
For example. If field-0 or field-1 had valid values at index 2 (hence validity bit 1 at index 2), these values - 'homer' and 3 - would be hidden indeed by the struct's validity bit 0 at index 2. |
Ah, do you focus on the part?
I see. Could you open a pull request to fix the example validity bitmaps? |
I'll do it. |
…38898) ### Rationale for this change See the issue. ### What changes are included in this PR? The struct example now demonstrates what it's supposed to. ### Are these changes tested? Renders well ### Are there any user-facing changes? Just docs. * Closes: #38883 Authored-by: Stas Stepanov <78556261+stfdxv@users.noreply.github.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…try (apache#38898) ### Rationale for this change See the issue. ### What changes are included in this PR? The struct example now demonstrates what it's supposed to. ### Are these changes tested? Renders well ### Are there any user-facing changes? Just docs. * Closes: apache#38883 Authored-by: Stas Stepanov <78556261+stfdxv@users.noreply.github.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…try (apache#38898) ### Rationale for this change See the issue. ### What changes are included in this PR? The struct example now demonstrates what it's supposed to. ### Are these changes tested? Renders well ### Are there any user-facing changes? Just docs. * Closes: apache#38883 Authored-by: Stas Stepanov <78556261+stfdxv@users.noreply.github.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Describe the bug, including details regarding any error messages, version, and platform.
Valid children values are not hidden by the struct's validity bitmap in the example, but the abstract says they are.
Struct's validity bitmap: 00001011
Field-0's validity bitmap: 00001001
Field-1's validity bitmap: 00001011
Component(s)
Website
The text was updated successfully, but these errors were encountered: