Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] [Parquet] Move EstimatedBufferedValueBytes from TypedColumnWriter to ColumnWriter #38887

Closed
Hattonuri opened this issue Nov 26, 2023 · 2 comments · Fixed by #39055
Closed

[C++] [Parquet] Move EstimatedBufferedValueBytes from TypedColumnWriter to ColumnWriter #38887

Hattonuri opened this issue Nov 26, 2023 · 2 comments · Fixed by #39055
Assignees
@mapleFU
Labels
Breaking Change Includes a breaking change to the API Component: C++ Component: Parquet Type: enhancement
Milestone
15.0.0

Comments

@Hattonuri
Copy link
Contributor

Describe the enhancement requested

Now, i can't easily use this method on array of columns and i need to cast these columns on hot path to calculate estimated total size. This method does not use DType of TypedColumnWriter so can be easily moved to its parent

Component(s)

C++, Parquet
@mapleFU
Copy link
Member

mapleFU commented Nov 27, 2023

I'll finish it today

@mapleFU
Copy link
Member

mapleFU commented Nov 27, 2023

take

@github-actions github-actions bot mentioned this issue Dec 3, 2023
Merged
mapleFU added a commit that referenced this issue Dec 6, 2023
@mapleFU
GH-38887: [C++][Parquet] Move EstimatedBufferedValueBytes from TypedC…
1cc1f4c 
…olumnWriter to ColumnWriter (#39055)

### Rationale for this change

Trying to put `EstimatedBufferedValueBytes` from `TypedColumnWriter` to `ColumnWriter`.

### What changes are included in this PR?

put `EstimatedBufferedValueBytes` from `TypedColumnWriter` to `ColumnWriter`.

### Are these changes tested?

No, just interface change

### Are there any user-facing changes?

Yes, interface changed

* Closes: #38887

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: mwish <maplewish117@gmail.com>
@mapleFU mapleFU added this to the 15.0.0 milestone Dec 6, 2023
@amoeba amoeba added the Breaking Change Includes a breaking change to the API label Jan 13, 2024
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@mapleFU @dgreiss
apacheGH-38887: [C++][Parquet] Move EstimatedBufferedValueBytes from …
e790cea 
…TypedColumnWriter to ColumnWriter (apache#39055)

### Rationale for this change

Trying to put `EstimatedBufferedValueBytes` from `TypedColumnWriter` to `ColumnWriter`.

### What changes are included in this PR?

put `EstimatedBufferedValueBytes` from `TypedColumnWriter` to `ColumnWriter`.

### Are these changes tested?

No, just interface change

### Are there any user-facing changes?

Yes, interface changed

* Closes: apache#38887

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: mwish <maplewish117@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapleFU mapleFU

Labels
Breaking Change Includes a breaking change to the API Component: C++ Component: Parquet Type: enhancement
Projects
None yet
Milestone
15.0.0
3 participants
@amoeba @mapleFU @Hattonuri