Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R] altrep.cpp contains errors in printf syntax #38893

Closed
paleolimbot opened this issue Nov 27, 2023 · 0 comments · Fixed by #38894
Closed

[R] altrep.cpp contains errors in printf syntax #38893

paleolimbot opened this issue Nov 27, 2023 · 0 comments · Fixed by #38894
Assignees
@paleolimbot
Labels
Component: R Type: bug
Milestone
14.0.2

Comments

@paleolimbot
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

On CI and some nightlies and CRAN we get:

Version: 14.0.0
Check: whether package can be installed
Result: WARN
  Found the following significant warnings:
    altrep.cpp:155:55: warning: format specifies type 'int' but the argument has type 'R_xlen_t' (aka 'long') [-Wformat]
    altrep.cpp:160:15: warning: format specifies type 'int' but the argument has type 'int64_t' (aka 'long') [-Wformat]
    altrep.cpp:160:44: warning: format specifies type 'int' but the argument has type 'int64_t' (aka 'long') [-Wformat]
    altrep.cpp:822:16: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
  See ‘/data/gannet/ripley/R/packages/tests-clang/arrow.Rcheck/00install.out’ for details.
  * used C++ compiler: ‘clang version 17.0.5’
Flavor: r-devel-linux-x86_64-fedora-clang

The code pathways here are infrequently taken but do need to be fixed.

Component(s)

R
@github-actions github-actions bot mentioned this issue Nov 27, 2023
Merged
assignUser pushed a commit that referenced this issue Nov 27, 2023
@paleolimbot
GH-38893: [R] Fix printf syntax in altrep.cpp (#38894)
9cece9d 
### Rationale for this change

We have CI errors and CRAN check errors on R-devel, where the appropriate attribute for printf format checking was just added.

### What changes are included in this PR?

The appopriate types are now used for printf parameters.

### Are these changes tested?

Covered by existing tests

### Are there any user-facing changes?

No
* Closes: #38893

Authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@assignUser assignUser added this to the 14.0.2 milestone Nov 27, 2023
raulcd pushed a commit that referenced this issue Nov 28, 2023
@paleolimbot @raulcd
GH-38893: [R] Fix printf syntax in altrep.cpp (#38894)
1484635 
### Rationale for this change

We have CI errors and CRAN check errors on R-devel, where the appropriate attribute for printf format checking was just added.

### What changes are included in this PR?

The appopriate types are now used for printf parameters.

### Are these changes tested?

Covered by existing tests

### Are there any user-facing changes?

No
* Closes: #38893

Authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
assignUser pushed a commit to assignUser/arrow that referenced this issue Dec 1, 2023
@paleolimbot @assignUser
apacheGH-38893: [R] Fix printf syntax in altrep.cpp (apache#38894)
8a6c06e 
### Rationale for this change

We have CI errors and CRAN check errors on R-devel, where the appropriate attribute for printf format checking was just added.

### What changes are included in this PR?

The appopriate types are now used for printf parameters.

### Are these changes tested?

Covered by existing tests

### Are there any user-facing changes?

No
* Closes: apache#38893

Authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@paleolimbot @dgreiss
apacheGH-38893: [R] Fix printf syntax in altrep.cpp (apache#38894)
8ff5b1e 
### Rationale for this change

We have CI errors and CRAN check errors on R-devel, where the appropriate attribute for printf format checking was just added.

### What changes are included in this PR?

The appopriate types are now used for printf parameters.

### Are these changes tested?

Covered by existing tests

### Are there any user-facing changes?

No
* Closes: apache#38893

Authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paleolimbot paleolimbot

Labels
Component: R Type: bug
Projects
None yet
Milestone
14.0.2
Development

Successfully merging a pull request may close this issue.

GH-38893: [R] Fix printf syntax in altrep.cpp paleolimbot/arrow
2 participants
@paleolimbot @assignUser