You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Windows R-devel build is failing on CI because one of our dependencies (cpp11) has an invalid format string in a rarely-used function in its header ( r-lib/cpp11#345 ) and we convert all errors to warnings (apparently, according to the output).
To fix this we can:
Not test r-devel on Windows for every commit (and ensure we do so on nightly, which I'm pretty sure we do, but worth checking before removing this job)
Find where we convert warnings to errors and stop doing that
Check to see if some other flag is causing this to occur (maybe -O0?)
I don't think we can or should wait for the PR linked above to merge upstream since this is causing CI to fail for all R PRs.
### Rationale for this change
The Windows/R-devel job is causing CI to fail on many PRs that are unrelated to Windows/R-devel. We also have some outdated version numbers in the Windows action.
### What changes are included in this PR?
The version for Windows was updated to "release", which should keep it current without explicit maintenance (since clearly we had forgotten to update the version numbers ourselves 😬 ). The devel version was removed because (1) it is failing and won't stop failing until an upstream PR to cpp11 is merged and (2) it's unclear to me that this check adds anything useful (we already test r-devel in another commit-level job). It may have dated from a time that r-devel on Windows was much different than r-release (it no longer is).
### Are these changes tested?
Yes
### Are there any user-facing changes?
No
* Closes: #38906
Authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
### Rationale for this change
The Windows/R-devel job is causing CI to fail on many PRs that are unrelated to Windows/R-devel. We also have some outdated version numbers in the Windows action.
### What changes are included in this PR?
The version for Windows was updated to "release", which should keep it current without explicit maintenance (since clearly we had forgotten to update the version numbers ourselves 😬 ). The devel version was removed because (1) it is failing and won't stop failing until an upstream PR to cpp11 is merged and (2) it's unclear to me that this check adds anything useful (we already test r-devel in another commit-level job). It may have dated from a time that r-devel on Windows was much different than r-release (it no longer is).
### Are these changes tested?
Yes
### Are there any user-facing changes?
No
* Closes: apache#38906
Authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
Describe the bug, including details regarding any error messages, version, and platform.
Follow-up on #38894 (comment) :
The Windows R-devel build is failing on CI because one of our dependencies (cpp11) has an invalid format string in a rarely-used function in its header ( r-lib/cpp11#345 ) and we convert all errors to warnings (apparently, according to the output).
To fix this we can:
-O0
?)I don't think we can or should wait for the PR linked above to merge upstream since this is causing CI to fail for all R PRs.
cc @assignUser
Component(s)
R
The text was updated successfully, but these errors were encountered: