Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] xsimd is used in public headers #38907

Closed
kou opened this issue Nov 28, 2023 · 0 comments · Fixed by #38908
Closed

[C++] xsimd is used in public headers #38907

kou opened this issue Nov 28, 2023 · 0 comments · Fixed by #38908
Assignees
@kou
Labels
Component: C++ Type: enhancement
Milestone
15.0.0

Comments

@kou
Copy link
Member

kou commented Nov 28, 2023

Describe the enhancement requested

cpp/src/arrow/util/bpacking_simd*_generated.h are installed and they include xsimd/xsimd.hpp.

Component(s)

C++
@kou kou changed the title [C++] Stop using xsimd in public header [C++] xsimd is used in public headers Nov 28, 2023
kou added a commit to kou/arrow that referenced this issue Nov 28, 2023
@kou
apacheGH-38907: [C++] Stop installing internal bpacking_simd* headers
70491af
@github-actions github-actions bot mentioned this issue Nov 28, 2023
Merged
@pitrou pitrou added this to the 15.0.0 milestone Nov 29, 2023
pitrou pushed a commit that referenced this issue Nov 29, 2023
@kou
GH-38907: [C++] Stop installing internal bpacking_simd* headers (#38908)
9aff60a 
### Rationale for this change

They are for internal use. We don't need to install them.

### What changes are included in this PR?

Use `_internal.h` suffix to avoid installing them.
 
### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #38907

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit to dgreiss/arrow that referenced this issue Feb 19, 2024
@kou @dgreiss
apacheGH-38907: [C++] Stop installing internal bpacking_simd* headers (…
49f6d98 
…apache#38908)

### Rationale for this change

They are for internal use. We don't need to install them.

### What changes are included in this PR?

Use `_internal.h` suffix to avoid installing them.
 
### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: apache#38907

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
15.0.0
Development

Successfully merging a pull request may close this issue.

GH-38907: [C++] Stop installing internal bpacking_simd* headers kou/arrow
2 participants
@kou @pitrou